From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754773AbbKMO1o (ORCPT ); Fri, 13 Nov 2015 09:27:44 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36961 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753799AbbKMO1m (ORCPT ); Fri, 13 Nov 2015 09:27:42 -0500 Subject: Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init To: Maxime Ripard References: <1447353613-18778-1-git-send-email-daniel.lezcano@linaro.org> <20151112233129.GH32142@lukather> Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, "moderated list:ARM/Allwinner A1X..." From: Daniel Lezcano Message-ID: <5645F35B.7090503@linaro.org> Date: Fri, 13 Nov 2015 15:27:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151112233129.GH32142@lukather> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2015 12:31 AM, Maxime Ripard wrote: > On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote: >> The current code to initialize, register and read the clocksource is >> already factored out in mmio.c via the clocksource_mmio_init function. >> >> The only difference is the readl vs readl_relaxed. >> >> Factor out the code with the clocksource_mmio_init function. >> >> Signed-off-by: Daniel Lezcano > > Acked-by: Maxime Ripard Thanks for the review. I applied the patch with a fix: ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1), node->name, rate, 340, UINT_MAX, clocksource_mmio_readl_down); Replaced UINT_MAX by '32'. -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog