public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
	Nizam Haider <nizamhaider786@gmail.com>
Cc: knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, Nizam Haider <nijamh@cdac.in>
Subject: Re: [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area
Date: Sat, 14 Nov 2015 17:21:48 +0000	[thread overview]
Message-ID: <56476DAC.6030903@kernel.org> (raw)
In-Reply-To: <5646FEC7.5050600@metafoo.de>

On 14/11/15 09:28, Lars-Peter Clausen wrote:
> On 11/14/2015 03:44 AM, Nizam Haider wrote:
>> Fix simple typo in comments
>>
>> Signed-off-by: Nizam Haider <nijamh@cdac.in>
> 
> Thanks for the patch.
> 
>> ---
>>  drivers/staging/iio/iio_simple_dummy_buffer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/iio_simple_dummy_buffer.c b/drivers/staging/iio/iio_simple_dummy_buffer.c
>> index cf44a6f..c8f889b 100644
>> --- a/drivers/staging/iio/iio_simple_dummy_buffer.c
>> +++ b/drivers/staging/iio/iio_simple_dummy_buffer.c
>> @@ -64,7 +64,7 @@ static irqreturn_t iio_simple_dummy_trigger_h(int irq, void *p)
>>  		 * software scans: can be considered to be random access
>>  		 *   so efficient reading is just a case of minimal bus
>>  		 *   transactions.
>> -		 * software culled hardware scans:
>> +		 * software called hardware scans:
> 
> I don't think that's a typo. The non-patched version makes a lot more sense
> then the patched vesion.
Yup, that's me using some 'more unusual' English terminology, Perhaps the word
'dropped' would be clearer.

Also, that comment is now a little misleading as it is unusual / undesirable
to now do this in an individual driver.  The core demux code should take care
of it.

Hmm.. I'll make a note to reread the comments in that driver and see if any
others could do with a refresh.

Jonathan
> 
>>  		 *   occasionally a driver may process the nearest hardware
>>  		 *   scan to avoid storing elements that are not desired. This
>>  		 *   is the fiddliest option by far.
>>
> 


  reply	other threads:[~2015-11-14 17:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14  2:44 [PATCH] Staging: iio: iio_simple_dummy_buffer: Typo in comments area Nizam Haider
2015-11-14  9:28 ` Lars-Peter Clausen
2015-11-14 17:21   ` Jonathan Cameron [this message]
2015-11-15 11:35     ` Nizam Haider
2015-11-15 12:25       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56476DAC.6030903@kernel.org \
    --to=jic23@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nijamh@cdac.in \
    --cc=nizamhaider786@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox