From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509AbbKOKms (ORCPT ); Sun, 15 Nov 2015 05:42:48 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:45892 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbbKOKmn (ORCPT ); Sun, 15 Nov 2015 05:42:43 -0500 Subject: Re: [PATCH] iio: adc: xilinx: Fix VREFN scale To: Thomas Betker , linux-iio@vger.kernel.org, Hartmut Knaack References: <1447273478-2530-1-git-send-email-thomas.betker@freenet.de> Cc: Lars-Peter Clausen , Peter Meerwald , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Xander Huff , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Betker From: Jonathan Cameron Message-ID: <5648619F.4040208@kernel.org> Date: Sun, 15 Nov 2015 10:42:39 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447273478-2530-1-git-send-email-thomas.betker@freenet.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/15 20:24, Thomas Betker wrote: > From: Thomas Betker > > The scaling factor for VREFN is 3.0/4096 (not 1.0/4096), just as for > VREFP. This is not immediately obvious from the specification (Xilinx > UG480), but has been confirmed by Xilinx support. > > Suggested-by: Hartmut Knaack > Signed-off-by: Thomas Betker Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan > --- > drivers/iio/adc/xilinx-xadc-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c > index 0370624..02e636a 100644 > --- a/drivers/iio/adc/xilinx-xadc-core.c > +++ b/drivers/iio/adc/xilinx-xadc-core.c > @@ -841,6 +841,7 @@ static int xadc_read_raw(struct iio_dev *indio_dev, > case XADC_REG_VCCINT: > case XADC_REG_VCCAUX: > case XADC_REG_VREFP: > + case XADC_REG_VREFN: > case XADC_REG_VCCBRAM: > case XADC_REG_VCCPINT: > case XADC_REG_VCCPAUX: >