From: Jonathan Cameron <jic23@kernel.org>
To: Nizam Haider <nizamhaider786@gmail.com>, gregkh@linuxfoundation.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
marex@denx.de, stefan.wahren@i2se.com,
kristina.martsenko@gmail.com, ciorneiioana@gmail.com,
hamohammed.sa@gmail.com, alexandre.belloni@free-electrons.com,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, Nizam Haider <nijamh@cdac.in>
Subject: Re: [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro
Date: Sun, 15 Nov 2015 11:12:20 +0000 [thread overview]
Message-ID: <56486894.20105@kernel.org> (raw)
In-Reply-To: <1447079162-12531-1-git-send-email-nizamhaider786@gmail.com>
On 09/11/15 14:26, Nizam Haider wrote:
> Replaces bit shifting on 1 with the BIT(x) macro
>
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
Applied to the togreg branch of iio.git - guess I'm going to start
getting the autobuilder warnings shortly!
Will be pushed out as testing for the autobuilders to play with it.
Jonathan
> ---
> drivers/staging/iio/adc/mxs-lradc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
> index d997d9c..5f1375c 100644
> --- a/drivers/staging/iio/adc/mxs-lradc.c
> +++ b/drivers/staging/iio/adc/mxs-lradc.c
> @@ -324,7 +324,7 @@ struct mxs_lradc {
> #define LRADC_DELAY_TRIGGER(x) \
> (((x) << LRADC_DELAY_TRIGGER_LRADCS_OFFSET) & \
> LRADC_DELAY_TRIGGER_LRADCS_MASK)
> -#define LRADC_DELAY_KICK (1 << 20)
> +#define LRADC_DELAY_KICK BIT(20)
> #define LRADC_DELAY_TRIGGER_DELAYS_MASK (0xf << 16)
> #define LRADC_DELAY_TRIGGER_DELAYS_OFFSET 16
> #define LRADC_DELAY_TRIGGER_DELAYS(x) \
>
prev parent reply other threads:[~2015-11-15 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 14:26 [PATCH] iio: adc: mxs-lradc: Prefer using the BIT macro Nizam Haider
2015-11-09 14:40 ` kbuild test robot
2015-11-15 11:10 ` Jonathan Cameron
2015-11-15 11:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56486894.20105@kernel.org \
--to=jic23@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=ciorneiioana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=knaack.h@gmx.de \
--cc=kristina.martsenko@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=nijamh@cdac.in \
--cc=nizamhaider786@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox