From: Jonathan Cameron <jic23@kernel.org>
To: Nizam Haider <nizamhaider786@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Nizam Haider <nijamh@cdac.in>
Subject: Re: [PATCH] iio: adc: ad7793: removed unnecessary else.
Date: Sun, 15 Nov 2015 11:14:42 +0000 [thread overview]
Message-ID: <56486922.4030705@kernel.org> (raw)
In-Reply-To: <1447073445-9231-1-git-send-email-nizamhaider786@gmail.com>
On 09/11/15 12:50, Nizam Haider wrote:
> Else is not generally useful after a break or return.
>
> Signed-off-by: Nizam Haider <nijamh@cdac.in>
Applied, thanks.
Jonathan
> ---
> drivers/iio/adc/ad7793.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index eea0c79..3bc5655 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -478,10 +478,9 @@ static int ad7793_read_raw(struct iio_dev *indio_dev,
> *val2 = st->
> scale_avail[(st->conf >> 8) & 0x7][1];
> return IIO_VAL_INT_PLUS_NANO;
> - } else {
> - /* 1170mV / 2^23 * 6 */
> - scale_uv = (1170ULL * 1000000000ULL * 6ULL);
> }
> + /* 1170mV / 2^23 * 6 */
> + scale_uv = (1170ULL * 1000000000ULL * 6ULL);
> break;
> case IIO_TEMP:
> /* 1170mV / 0.81 mV/C / 2^23 */
>
prev parent reply other threads:[~2015-11-15 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 12:50 [PATCH] iio: adc: ad7793: removed unnecessary else Nizam Haider
2015-11-15 11:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56486922.4030705@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nijamh@cdac.in \
--cc=nizamhaider786@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox