From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbbKPOJE (ORCPT ); Mon, 16 Nov 2015 09:09:04 -0500 Received: from mail3.start.ca ([64.140.120.243]:37705 "EHLO mail3.start.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751214AbbKPOJB (ORCPT ); Mon, 16 Nov 2015 09:09:01 -0500 X-Greylist: delayed 1278 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 Nov 2015 09:09:00 EST Subject: Re: [PATCH v2] libata: add support for NCQ commands for SG interface To: vinayak.kale@gmail.com, tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <1445924955-11124-1-git-send-email-vinayak.kale@seagate.com> Cc: sumit.g.gupta@seagate.com, Vinayak Kale From: Mark Lord Message-ID: <5649DE67.7080509@start.ca> Date: Mon, 16 Nov 2015 08:47:19 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445924955-11124-1-git-send-email-vinayak.kale@seagate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-10-27 01:49 AM, vinayak.kale@gmail.com wrote: > From: Vinayak Kale > > This patch is needed to make NCQ commands with FPDMA protocol value > (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. .. > + /* For NCQ commands with FPDMA protocol, copy the tag value */ > + if (tf->protocol == ATA_PROT_NCQ) > + tf->nsect = qc->tag << 3; > + What prevents the qc-tag value here from conflicting with in-flight I/O using the exact same qc-tag ??