From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbbKQKJS (ORCPT ); Tue, 17 Nov 2015 05:09:18 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:33627 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbbKQKJP (ORCPT ); Tue, 17 Nov 2015 05:09:15 -0500 Subject: Re: [PATCH] regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C To: Henry Chen , Mark Brown References: <1447749409-19900-1-git-send-email-henryc.chen@mediatek.com> Cc: Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, eddie.huang@mediatek.com From: Matthias Brugger Message-ID: <564AFCC8.6000604@gmail.com> Date: Tue, 17 Nov 2015 11:09:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447749409-19900-1-git-send-email-henryc.chen@mediatek.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/11/15 09:36, Henry Chen wrote: > This patch fix the below build error: > drivers/regulator/mt6311-regulator.c:111: undefined reference to `__devm_regmap_init_i2c' > > Signed-off-by: Henry Chen > --- > drivers/regulator/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig > index 8df0b0e..0067620 100644 > --- a/drivers/regulator/Kconfig > +++ b/drivers/regulator/Kconfig > @@ -446,6 +446,7 @@ config REGULATOR_MC13892 > config REGULATOR_MT6311 > tristate "MediaTek MT6311 PMIC" > depends on I2C > + select REGMAP_I2C > help > Say y here to select this option to enable the power regulator of > MediaTek MT6311 PMIC. > This should also be added to v4.3 I propose that you resend it adding the tag: Cc: stable@vger.kernel.org as explained in Documentation/stable_kernel_rules.txt Regards, Matthias