[PATCH] regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C

[PATCH] regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C

[Henry Chen]

This patch fix the below build error:
drivers/regulator/mt6311-regulator.c:111: undefined reference to `__devm_regmap_init_i2c'

Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 8df0b0e..0067620 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -446,6 +446,7 @@ config REGULATOR_MC13892
 config REGULATOR_MT6311
 	tristate "MediaTek MT6311 PMIC"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say y here to select this option to enable the power regulator of
 	  MediaTek MT6311 PMIC.
-- 
1.9.1

Re: [PATCH] regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C

[Matthias Brugger]

On 17/11/15 09:36, Henry Chen wrote:
> This patch fix the below build error:
> drivers/regulator/mt6311-regulator.c:111: undefined reference to `__devm_regmap_init_i2c'
>
> Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> ---
>   drivers/regulator/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 8df0b0e..0067620 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -446,6 +446,7 @@ config REGULATOR_MC13892
>   config REGULATOR_MT6311
>   	tristate "MediaTek MT6311 PMIC"
>   	depends on I2C
> +	select REGMAP_I2C
>   	help
>   	  Say y here to select this option to enable the power regulator of
>   	  MediaTek MT6311 PMIC.
>

This should also be added to v4.3
I propose that you resend it adding the tag:
Cc: stable@vger.kernel.org

as explained in Documentation/stable_kernel_rules.txt

Regards,
Matthias

Re: [PATCH] regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

On Tue, Nov 17, 2015 at 11:09:12AM +0100, Matthias Brugger wrote:

> This should also be added to v4.3
> I propose that you resend it adding the tag:
> Cc: stable@vger.kernel.org

> as explained in Documentation/stable_kernel_rules.txt

Please don't, that just makes more work for me having to deal with two
copies of the mail.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Applied "regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C" to the regulator tree

[Mark Brown]

The patch

   regulator: mt6311: MT6311_REGULATOR needs to select REGMAP_I2C

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From aab3c3f34cc2dd8230052770712606d65de6538f Mon Sep 17 00:00:00 2001
From: Henry Chen <henryc.chen@mediatek.com>
Date: Tue, 17 Nov 2015 16:36:49 +0800
Subject: [PATCH] regulator: mt6311: MT6311_REGULATOR needs to select
 REGMAP_I2C

This patch fix the below build error:
drivers/regulator/mt6311-regulator.c:111: undefined reference to `__devm_regmap_init_i2c'

Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
---
 drivers/regulator/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 8df0b0e62976..00676208080e 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -446,6 +446,7 @@ config REGULATOR_MC13892
 config REGULATOR_MT6311
 	tristate "MediaTek MT6311 PMIC"
 	depends on I2C
+	select REGMAP_I2C
 	help
 	  Say y here to select this option to enable the power regulator of
 	  MediaTek MT6311 PMIC.
-- 
2.6.2