From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753142AbbKQNzL (ORCPT ); Tue, 17 Nov 2015 08:55:11 -0500 Received: from lists.s-osg.org ([54.187.51.154]:57784 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbbKQNzJ (ORCPT ); Tue, 17 Nov 2015 08:55:09 -0500 Subject: Re: [PATCH 1/3] mtd: m25p80: fix module autoloading for "jedec,spi-nor" and "spi-nor" To: Brian Norris , linux-mtd@lists.infradead.org References: <1447713292-91525-1-git-send-email-computersforpeace@gmail.com> <1447713292-91525-2-git-send-email-computersforpeace@gmail.com> From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Cc: linux-kernel@vger.kernel.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Heiner Kallweit Message-ID: <564B31B8.70104@osg.samsung.com> Date: Tue, 17 Nov 2015 10:55:04 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447713292-91525-2-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Brian, On 11/16/2015 07:34 PM, Brian Norris wrote: > Commit 43163022927b ("mtd: m25p80: allow arbitrary OF matching for > "jedec,spi-nor"") moved the "jedec,spi-nor" handling from the > spi_device_id table to the of_match_table, to better handle matching > complex device tree compatible strings. With that patch, device tree > support works as expected when m25p80.c is built into the kernel. > > However, that commit ignored the fact that: > > (1) (non-DT) platform devices might want to use the "spi-nor" string > for matching with this driver, rather than picking an arbitrary one > like "m25p80" > (2) the core SPI uevent/modalias code doesn't yet support kernel module > autoloading via of_match_table strings; so for DT-based devices, it > will only report (part of) the first compatible string used > Very nice changelog message! Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America