From: "Andrew F. Davis" <afd@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/6] gpio: tps65086: Add GPIO driver for the TPS65086 PMIC
Date: Tue, 17 Nov 2015 10:11:31 -0600 [thread overview]
Message-ID: <564B51B3.2000102@ti.com> (raw)
In-Reply-To: <CACRpkdb1V7JxLSbwqf4CX+nDLeQzP=bOA9YMXzE4CFTQfzRL9w@mail.gmail.com>
On 11/17/2015 03:17 AM, Linus Walleij wrote:
> On Wed, Nov 4, 2015 at 6:12 PM, Andrew F. Davis <afd@ti.com> wrote:
>
>> Add support for the TPS65086 PMIC GPOs.
>>
>> TPS65086 has four configurable GPOs that can be used for several
>> purposes.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>
> OK...
>
>> +static int tps65086_gpio_get(struct gpio_chip *gc, unsigned offset)
>> +static void tps65086_gpio_set(struct gpio_chip *gc, unsigned offset,
>
> Just get/set and no get_direction/direction_input/direction_output?
> Are you sure?
>
Yeah, these are output only, I could probably add get_direction and just
always return output, but setters wouldn't make sense here.
Andrew
> Yours,
> Linus Walleij
>
next prev parent reply other threads:[~2015-11-17 16:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 17:12 [PATCH v3 0/6] Add support for the TI TPS65086 PMIC Andrew F. Davis
2015-11-04 17:12 ` [PATCH v3 1/6] Documentation: tps65086: Add DT bindings for the " Andrew F. Davis
2015-11-04 22:55 ` Rob Herring
2015-11-04 17:12 ` [PATCH v3 2/6] Documentation: tps65086: Add DT bindings for the TPS65086 regulators Andrew F. Davis
2015-11-04 22:51 ` Rob Herring
2015-11-04 17:12 ` [PATCH v3 3/6] Documentation: tps65086: Add DT bindings for the TPS65086 GPO controller Andrew F. Davis
2015-11-04 22:57 ` Rob Herring
2015-11-17 9:12 ` Linus Walleij
2015-11-04 17:12 ` [PATCH v3 4/6] mfd: tps65086: Add driver for the TPS65086 PMIC Andrew F. Davis
2015-11-04 17:12 ` [PATCH v3 5/6] regulator: tps65086: Add regulator " Andrew F. Davis
2015-11-04 17:12 ` [PATCH v3 6/6] gpio: tps65086: Add GPIO " Andrew F. Davis
2015-11-17 9:17 ` Linus Walleij
2015-11-17 16:11 ` Andrew F. Davis [this message]
2015-11-18 9:44 ` Linus Walleij
2015-11-18 16:41 ` Andrew F. Davis
2015-11-30 8:28 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B51B3.2000102@ti.com \
--to=afd@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox