From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754953AbbKRAo4 (ORCPT ); Tue, 17 Nov 2015 19:44:56 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:40903 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbbKRAoy (ORCPT ); Tue, 17 Nov 2015 19:44:54 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-7e-564bca0253bf Subject: Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <8497197.sYxqVOch7s@wuerfel> <4389196.cuM78vZZnJ@wuerfel> <564A899C.4040402@samsung.com> <4654010.UfKTsDKyes@wuerfel> Cc: "Rafael J. Wysocki" , linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, Viresh Kumar , linux-kernel@vger.kernel.org, Kukjin Kim From: Krzysztof Kozlowski Message-id: <564BCA00.3040906@samsung.com> Date: Wed, 18 Nov 2015 09:44:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <4654010.UfKTsDKyes@wuerfel> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRmVeSWpSXmKPExsVy+t/xq7pMp7zDDO7NkrP4O+kYu8XrF4YW /Y9fM1tsenyN1eLyrjlsFp97jzBazDi/j8nizOlLrBYbv3o4cHr8/jWJ0WPTqk42jzvX9rB5 bF5S77HlajuLR9+WVYwenzfJBbBHcdmkpOZklqUW6dslcGXs/byPteAcZ8XDS89YGhh3sXcx cnJICJhIPD3fzwRhi0lcuLeerYuRi0NIYCmjxOllT5kgnC+MEgsv7mYFqRIWcJHo/PsEzBYR cJdYN30eK0RRM6NE+5zdzCAOs8BFRolNDdfYQKrYBIwlNi9fAmRzcPAKaElMOxcFEmYRUJW4 sv4hI4gtKhAhMXFCA9hQXgFBiR+T77GA2JwCmhI/J5xgAWllFtCTuH9RCyTMLCAvsXnNW+YJ jAKzkHTMQqiahaRqASPzKkbR1NLkguKk9FxDveLE3OLSvHS95PzcTYyQOPiyg3HxMatDjAIc jEo8vAmLvcOEWBPLiitzDzFKcDArifBePQwU4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt31/sQ IYH0xJLU7NTUgtQimCwTB6dUA+MczuS5Ga3z6j9c4Hqnuz7QSrJZ2X/Lwaa30vl/IjjD36sd /Oq4KkyNTXxifIsFZ9/O2nVvth9SjP70SmX9y5tpbM67J6q9fBB2TfdVl2vX8WVm91PeWx4q Zz4spPo+VO8Wb0dyrZC1XeD3vyWz6u/yzdKK8Mj/+1p8cmxR47kr28z7P+iJ+SixFGckGmox FxUnAgCj+2u5fwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.11.2015 18:01, Arnd Bergmann wrote: > On Tuesday 17 November 2015 10:57:48 Krzysztof Kozlowski wrote: >> On 17.11.2015 07:17, Arnd Bergmann wrote: >>> On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote: >>>> >>>> This should go in through the Samsung tree, so I'll leave it for them to pick >>>> it up (at least for the time being). >>> >>> Ok, fair enough. Kukjin or Krzysztof, can you pick this up? >> >> Sure. >> >> As for the patch I think everything can be converted to init/initdata >> (as in attachment). >> > > I don't think so: > > static struct subsys_interface s3c2442_plls169344_interface __initdata = { > .name = "s3c2442_plls169344", > .subsys = &s3c2442_subsys, > .add_dev = s3c2440_plls169344_add, > }; > > This gets passed into subsys_interface_register(), which is not __init > in turn. subsys_interface_register() then goes on to add > s3c2442_plls169344_interface into a linked list that is traversed > at runtime, but the __initdata section gets discarded so you now > have a broken list. Ah, yes, so the patch is fine: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof