From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932655AbbKRBe7 (ORCPT ); Tue, 17 Nov 2015 20:34:59 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:28020 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752856AbbKRBdr (ORCPT ); Tue, 17 Nov 2015 20:33:47 -0500 X-AuditID: cbfec7f5-f794b6d000001495-cd-564bd578023c Subject: Re: [PATCHv2] ASoC: samsung: pass DMA channels as pointers To: Arnd Bergmann , Mark Brown , alsa-devel@alsa-project.org References: <6346833.MfUC71I3uD@wuerfel> Cc: linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Sangbeom Kim , Liam Girdwood , linux-kernel@vger.kernel.org, Vinod Koul , Kukjin Kim , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <564BD575.3070702@samsung.com> Date: Wed, 18 Nov 2015 10:33:41 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <6346833.MfUC71I3uD@wuerfel> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42I5/e/4Fd2Kq95hBv/vqlpcuXiIyeLvpGPs FlMfPmGz+P/oNavF6xeGFv2PXzNbfLvSwWSx6fE1VovLu+awWcw4v4/J4uKKL0wWL/v2szjw eGz43MTm8fvXJEaPnbPusnss3vOSyWPTqk42j81L6j36tqxi9Nh+bR6zx+dNcgGcUVw2Kak5 mWWpRfp2CVwZX1/MYS94wl2x4PwRxgbGM5xdjJwcEgImEpt+LGCEsMUkLtxbz9bFyMUhJLCU UWLnjr0sEM4XRollaz6wgVQJCzhLvPp4jBXEFhFIlDj6dxUTiC0koCFx5d0aRpAGZoE5TBKn 2vrBitgEjCU2L18C1swroCWx9W8fM4jNIqAq8XTdJLAaUYEIiYkTGlghagQlfky+xwJicwpo Stz4swtoAQfQUD2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5KzzXS K07MLS7NS9dLzs/dxAiJna87GJceszrEKMDBqMTDm7jYO0yINbGsuDL3EKMEB7OSCO/Vw0Ah 3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MCryaX2KOLJY Q1CQz0FJuq7u1q8XBue2yvZbLevobX3zOevQsYUnLqUZv1/DpcV4fVP89pb0z15hWawMez54 SBhf2fEysK9DbsKD0+E+N19ZLl4ezftrt2b15AIm7vU6eXyP9Kfv5XimtGg5z9TT+xOEPXTN OTpjKle92Mtj9OLPX5dTx8xKeJVYijMSDbWYi4oTAe9EMlOZAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.11.2015 00:53, Arnd Bergmann wrote: > ARM64 allmodconfig produces a bunch of warnings when building the > samsung ASoC code: > > sound/soc/samsung/dmaengine.c: In function 'samsung_asoc_init_dma_data': > sound/soc/samsung/dmaengine.c:53:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > playback_data->filter_data = (void *)playback->channel; > sound/soc/samsung/dmaengine.c:60:31: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > capture_data->filter_data = (void *)capture->channel; > > We could easily shut up the warning by adding an intermediate cast, > but there is a bigger underlying problem: The use of IORESOURCE_DMA > to pass data from platform code to device drivers is dubious to start > with, as what we really want is a pointer that can be passed into > a filter function. > > Note that on s3c64xx, the pl08x DMA data is already a pointer, but > gets cast to resource_size_t so we can pass it as a resource, and it > then gets converted back to a pointer. In contrast, the data we pass > for s3c24xx is an index into a device specific table, and we artificially > convert that into a pointer for the filter function. > > Signed-off-by: Arnd Bergmann > --- > v2: > > - no longer clash with SPI patch > - don't reference platform data that might be NULL > Looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof