From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755221AbbKRBxd (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Nov 2015 20:53:33 -0500
Received: from mailout1.w1.samsung.com ([210.118.77.11]:24980 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752856AbbKRBxb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Nov 2015 20:53:31 -0500
X-AuditID: cbfec7f5-f794b6d000001495-a4-564bda17c820
Subject: Re: [PATCHv2 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data
To: Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>
References: <6346833.MfUC71I3uD@wuerfel> <4020501.kQLt6nnIEv@wuerfel>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
        Heiko Stuebner <heiko@sntech.de>, Sangbeom Kim <sbkim73@samsung.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org,
        Vinod Koul <vinod.koul@intel.com>, Kukjin Kim <kgene@kernel.org>,
        linux-arm-kernel@lists.infradead.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <564BDA13.3040907@samsung.com>
Date: Wed, 18 Nov 2015 10:53:23 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <4020501.kQLt6nnIEv@wuerfel>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42I5/e/4ZV2JW95hBhP1La5cPMRk8XfSMXaL
	qQ+fsFn8f/Sa1eL1C0OL/sevmS2+Xelgstj0+BqrxeVdc9gsZpzfx2RxccUXJouXfftZHHg8
	NnxuYvP4/WsSo8fOWXfZPRbvecnksWlVJ5vH5iX1Hn1bVjF6bL82j9nj8ya5AM4oLpuU1JzM
	stQifbsEroz+RYfZC9ZwVOxbcIqtgfEuWxcjJ4eEgInEgX3HGSFsMYkL99aDxYUEljJKnPpV
	3sXIBWR/YZQ429bJApIQFgiQmLq/kxnEFhFwkrh09CoLRIOrxIr7a1hAGpgFdjNJ/N40iRUk
	wSZgLLF5+RKgqRwcvAJaEq8m14GEWQRUJZ5/7wYrERWIkJg4oQHM5hUQlPgx+R7YTE4BTYln
	J2eBtTIL6Encv6gFEmYWkJfYvOYt8wRGgVlIOmYhVM1CUrWAkXkVo2hqaXJBcVJ6rpFecWJu
	cWleul5yfu4mRkjUfN3BuPSY1SFGAQ5GJR7exMXeYUKsiWXFlbmHGCU4mJVEeK8eBgrxpiRW
	VqUW5ccXleakFh9ilOZgURLnnbnrfYiQQHpiSWp2ampBahFMlomDU6qBMVy979zvhJ2cIQfC
	JxfHBlQeT3asv8PN8arvws5lSZxP1/FJVk9vTuYMfNGTsGXluitvXL9Glp16sPiTBSfvpVPv
	m9yLrr+/zS14OmdL1LLYhBsaq07/LYqRzuc7/EktIEDIv/DL7d37467fubr0/iTf+BfZP4+y
	Sl2d9uGj5t6ORc/LDjBn3VRiKc5INNRiLipOBAALPqTdlgIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18.11.2015 00:54, Arnd Bergmann wrote:
> This is a minor cleanup to make the s3c2412-i2s and s3c24xx-i2s
> drivers independent of the mach/dma.h header file and to allow
> removing the dependency on the specific dmaengine driver in the
> next patch.
> 
> As a side not, only the s3c24xx-i2s driver seems to still be
> used, while the definition of the s3c2412-i2s platform device was
> removed in commit 6d259a25b56d ("ARM: SAMSUNG: use static
> declaration when it is not used in other files") after it had
> never been referenced since its introduction in f0fba2ad1b6b
> ("ASoC: multi-component - ASoC Multi-Component Support").
> 
> Apparently it should have been used by mach-jive.c, but that
> never happened. My patch at this point leaves the current state
> unchanged, we can decide whether to fix or delete the jive
> driver and s3c2412-i2s another time.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: check for NULL pdata
> 

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof