From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755576AbbKRLKO (ORCPT ); Wed, 18 Nov 2015 06:10:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33871 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750883AbbKRLKN (ORCPT ); Wed, 18 Nov 2015 06:10:13 -0500 Subject: Re: [RFC PATCH 1/3] x86/cpu: Unify CPU family, model, stepping calculation To: Borislav Petkov , LKML References: <1447497436-26424-1-git-send-email-bp@alien8.de> <1447497436-26424-2-git-send-email-bp@alien8.de> Cc: X86 ML , KVM From: Paolo Bonzini Message-ID: <564C5C90.3080903@redhat.com> Date: Wed, 18 Nov 2015 12:10:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447497436-26424-2-git-send-email-bp@alien8.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/11/2015 11:37, Borislav Petkov wrote: > vendor = x86_vendor(); > - family = x86_family(); > + family = x86_family_cpuid(); What about renaming x86_vendor() so that this looks like - vendor = x86_vendor(); - family = x86_family(); + vendor = x86_cpuid_vendor(); + family = x86_cpuid_family(); Otherwise looks good. Paolo