public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules
@ 2015-11-17 15:58 Javier Martinez Canillas
  2015-11-18 12:47 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2015-11-17 15:58 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-samsung-soc, Krzysztof Kozlowski, Kevin Hilman,
	Arnd Bergmann, Kukjin Kim, Sjoerd Simons, Olof Johansson,
	linux-arm-kernel, Javier Martinez Canillas

Since the multi_v7_defconfig is used to build an image for different
platforms, the options should be enabled as module whenever possible.

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---
The patch was tested on an Exynos5800 Peach Pi Chromebook
and the drivers' modules were correctly autoloaded.

 arch/arm/configs/multi_v7_defconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 69a22fdb52a5..a38a1b0f2657 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -241,7 +241,7 @@ CONFIG_KEYBOARD_GPIO=y
 CONFIG_KEYBOARD_TEGRA=y
 CONFIG_KEYBOARD_SPEAR=y
 CONFIG_KEYBOARD_ST_KEYSCAN=y
-CONFIG_KEYBOARD_CROS_EC=y
+CONFIG_KEYBOARD_CROS_EC=m
 CONFIG_MOUSE_PS2_ELANTECH=y
 CONFIG_MOUSE_CYAPA=m
 CONFIG_MOUSE_ELAN_I2C=y
@@ -397,9 +397,9 @@ CONFIG_MFD_AS3722=y
 CONFIG_MFD_ATMEL_FLEXCOM=y
 CONFIG_MFD_BCM590XX=y
 CONFIG_MFD_AXP20X=y
-CONFIG_MFD_CROS_EC=y
+CONFIG_MFD_CROS_EC=m
 CONFIG_MFD_CROS_EC_I2C=m
-CONFIG_MFD_CROS_EC_SPI=y
+CONFIG_MFD_CROS_EC_SPI=m
 CONFIG_MFD_MAX14577=y
 CONFIG_MFD_MAX77686=y
 CONFIG_MFD_MAX77693=y
-- 
2.4.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules
  2015-11-17 15:58 [PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules Javier Martinez Canillas
@ 2015-11-18 12:47 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-18 12:47 UTC (permalink / raw)
  To: Javier Martinez Canillas, linux-kernel
  Cc: k.kozlowski.k, linux-samsung-soc, Kevin Hilman, Arnd Bergmann,
	Kukjin Kim, Sjoerd Simons, Olof Johansson, linux-arm-kernel

W dniu 18.11.2015 o 00:58, Javier Martinez Canillas pisze:
> Since the multi_v7_defconfig is used to build an image for different
> platforms, the options should be enabled as module whenever possible.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> The patch was tested on an Exynos5800 Peach Pi Chromebook
> and the drivers' modules were correctly autoloaded.
> 
>  arch/arm/configs/multi_v7_defconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I suppose this could go through Samsung-soc. I got few other patches for
multi_v7.

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-18 12:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-17 15:58 [PATCH] ARM: multi_v7_defconfig: Build ChromeOS EC drivers as modules Javier Martinez Canillas
2015-11-18 12:47 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox