From: Ian Abbott <abbotti@mev.co.uk>
To: Ranjith Thangavel <ranjithece24@gmail.com>, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro
Date: Wed, 18 Nov 2015 16:41:58 +0000 [thread overview]
Message-ID: <564CAA56.2030301@mev.co.uk> (raw)
In-Reply-To: <1447694308-7724-1-git-send-email-ranjithece24@gmail.com>
On 16/11/15 17:18, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator, usleep_range is preferred over
> udelay - coding style issue
This patch doesn't use usleep_range(), so the description is inaccurate.
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/dmm32at.c | 100 +++++++++++++++---------------
> 1 file changed, 50 insertions(+), 50 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c
> index 958c0d4..d312fda 100644
> --- a/drivers/staging/comedi/drivers/dmm32at.c
> +++ b/drivers/staging/comedi/drivers/dmm32at.c
[snip]
> -#define DMM32AT_AI_CFG_SCINT_20US (0 << 4)
> -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4)
> -#define DMM32AT_AI_CFG_SCINT_10US (2 << 4)
> -#define DMM32AT_AI_CFG_SCINT_5US (3 << 4)
> -#define DMM32AT_AI_CFG_RANGE (1 << 3) /* 0=5V 1=10V */
> -#define DMM32AT_AI_CFG_ADBU (1 << 2) /* 0=bipolar 1=unipolar */
> +#define DMM32AT_AI_CFG_SCINT_20US 0
> +#define DMM32AT_AI_CFG_SCINT_15US BIT(4)
> +#define DMM32AT_AI_CFG_SCINT_10US (BIT(5) & ~BIT(4))
The `(BIT(5) & ~BIT(4))` is a bit ugly. You can just use `BIT(5)` to
fit in with the style of your other changes.
(Personally though, I don't think BIT() is appropriate for shifted,
multi-bit values.)
> +#define DMM32AT_AI_CFG_SCINT_5US (BIT(5) | BIT(4))
> +#define DMM32AT_AI_CFG_RANGE BIT(3) /* 0=5V 1=10V */
> +#define DMM32AT_AI_CFG_ADBU BIT(2) /* 0=bipolar 1=unipolar */
[snip]
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-11-18 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 17:18 [PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro Ranjith Thangavel
2015-11-16 17:18 ` [PATCH 2/2] " Ranjith Thangavel
2015-11-17 16:26 ` Sudip Mukherjee
2015-11-17 16:24 ` [PATCH 1/2] " Sudip Mukherjee
2015-11-18 16:41 ` Ian Abbott [this message]
2015-11-18 16:45 ` Hartley Sweeten
2015-11-18 17:02 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CAA56.2030301@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox