public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jitendra <jkhasdev@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: mchehab@osg.samsung.com, devel@driverdev.osuosl.org,
	Jitendra Kumar Khasdev <jitendra.khasdev@hotwaxsystems.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c
Date: Wed, 18 Nov 2015 23:05:27 +0530	[thread overview]
Message-ID: <564CB6DF.5080700@gmail.com> (raw)
In-Reply-To: <20151118171221.GA13143@kroah.com>



On Wednesday 18 November 2015 10:42 PM, Greg KH wrote:
> On Wed, Nov 18, 2015 at 09:25:22PM +0530, Jitendra Kumar Khasdev wrote:
>> This is a patch to the radio-bcm2048.c file that fixes up a brace warning
>> found by the checkpatch.pl tool.
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>> ---
>>  drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> index b10d601..6226e02 100644
>> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
>> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
>> @@ -2021,8 +2021,8 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
>>  }
>>  
>>  #define DEFINE_SYSFS_PROPERTY(prop, signal, size, mask, check)		\
>> -property_write(prop, signal size, mask, check)				\
>> -property_read(prop, size, mask)
>> +(property_write(prop, signal size, mask, check)				\
>> +property_read(prop, size, mask))
> You didn't even test-build this patch, why not?
>
Greg KH, I have compiled the kernel by following these step:
                1. copied the .config files
                2. make defconfig
                3. make -j6
 It doesn't show me any warning. so I have tested on my side.
--
Thanks and Regards,
Jitendra Kumar Khasdev

  reply	other threads:[~2015-11-18 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 15:55 [PATCH] staging: media: bcm2048: fix brace coding style issue in radio-bcm2048.c Jitendra Kumar Khasdev
2015-11-18 16:08 ` kbuild test robot
2015-11-18 16:19 ` kbuild test robot
2015-11-18 17:12 ` Greg KH
2015-11-18 17:35   ` Jitendra [this message]
2015-11-18 18:07     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564CB6DF.5080700@gmail.com \
    --to=jkhasdev@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jitendra.khasdev@hotwaxsystems.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox