From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756493AbbKRTEZ (ORCPT ); Wed, 18 Nov 2015 14:04:25 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44102 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754016AbbKRTEY (ORCPT ); Wed, 18 Nov 2015 14:04:24 -0500 Subject: Re: [PATCH] iio: adc: xilinx: constify iio_buffer_setup_ops structure To: Lars-Peter Clausen , Julia Lawall References: <1447617602-12922-1-git-send-email-Julia.Lawall@lip6.fr> <5648E8DA.3070509@metafoo.de> Cc: kernel-janitors@vger.kernel.org, Hartmut Knaack , Peter Meerwald , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <564CCBB5.6000607@kernel.org> Date: Wed, 18 Nov 2015 19:04:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5648E8DA.3070509@metafoo.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/11/15 20:19, Lars-Peter Clausen wrote: > On 11/15/2015 09:00 PM, Julia Lawall wrote: >> The iio_buffer_setup_ops structures are never modified, so declare this one >> as const, like the others. >> >> Done with the help of Coccinelle. >> >> Signed-off-by: Julia Lawall > > Acked-by: Lars-Peter Clausen Applied. Thanks, Jonathan > > Thanks. > >> >> --- >> drivers/iio/adc/xilinx-xadc-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c >> index 0370624..c2b5f10 100644 >> --- a/drivers/iio/adc/xilinx-xadc-core.c >> +++ b/drivers/iio/adc/xilinx-xadc-core.c >> @@ -803,7 +803,7 @@ err: >> return ret; >> } >> >> -static struct iio_buffer_setup_ops xadc_buffer_ops = { >> +static const struct iio_buffer_setup_ops xadc_buffer_ops = { >> .preenable = &xadc_preenable, >> .postenable = &iio_triggered_buffer_postenable, >> .predisable = &iio_triggered_buffer_predisable, >> >