Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
       [not found] <COL130-W7B5F0BB94C76AF6B12EA7B91C0@phx.gbl>
@ 2015-11-19  0:11 ` Russell King - ARM Linux
  2015-11-19  6:14 ` Vineet Gupta
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2015-11-19  0:11 UTC (permalink / raw)
  To: Chen Gang
  Cc: vgupta@synopsys.com, dhowells@redhat.com, geert@linux-m68k.org,
	gerg@uclinux.org, jonas@southpole.se, Arnd Bergmann,
	abrodkin@synopsys.com, Andrew Morton,
	linux-snps-arc@lists.infradead.org, kernel mailing list,
	linux-arm-kernel@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, linux-arch@vger.kernel.org,
	linux

On Thu, Nov 19, 2015 at 03:40:25AM +0800, Chen Gang wrote:
> >From ba7c00c4cb976109b6a35812ce9649aaeda81e2d Mon Sep 17 00:00:00 2001
> From: Chen Gang <gang.chen.5i5j@gmail.com>
> Date: Thu, 19 Nov 2015 03:24:42 +0800
> Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
> 
> They are not symmetric with each other, neither are used in real world
> (can not be found by grep command in source code root directory), so
> remove them.
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

For:
>  arch/arm/include/asm/page-nommu.h | 3 ---

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
       [not found] <COL130-W7B5F0BB94C76AF6B12EA7B91C0@phx.gbl>
  2015-11-19  0:11 ` [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Russell King - ARM Linux
@ 2015-11-19  6:14 ` Vineet Gupta
  2015-11-19 11:25 ` Arnd Bergmann
  2015-11-20 12:15 ` Greg Ungerer
  3 siblings, 0 replies; 6+ messages in thread
From: Vineet Gupta @ 2015-11-19  6:14 UTC (permalink / raw)
  To: Chen Gang, dhowells@redhat.com, linux@arm.linux.org.uk,
	geert@linux-m68k.org, gerg@uclinux.org, jonas@southpole.se,
	Arnd Bergmann, abrodkin@synopsys.com, Andrew Morton
  Cc: linux-arch@vger.kernel.org, kernel mailing list,
	linux-m68k@lists.linux-m68k.org, linux,
	linux-snps-arc@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org

On Thursday 19 November 2015 01:10 AM, Chen Gang wrote:
> From ba7c00c4cb976109b6a35812ce9649aaeda81e2d Mon Sep 17 00:00:00 2001
> From: Chen Gang <gang.chen.5i5j@gmail.com>
> Date: Thu, 19 Nov 2015 03:24:42 +0800
> Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
> 
> They are not symmetric with each other, neither are used in real world
> (can not be found by grep command in source code root directory), so
> remove them.
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
>  arch/arc/include/asm/page.h       | 3 ---
>  arch/arm/include/asm/page-nommu.h | 3 ---
>  arch/frv/include/asm/page.h       | 3 ---
>  arch/m68k/include/asm/page_mm.h   | 3 ---
>  arch/m68k/include/asm/page_no.h   | 3 ---
>  arch/openrisc/include/asm/page.h  | 3 ---
>  include/asm-generic/page.h        | 3 ---
>  7 files changed, 21 deletions(-)

So this is one huge patch touching several arches with potential to cause
conflicts when merged. Can u divy them up and then the maintainers can simply
merge them individually given there is no common dependency !

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
       [not found] <COL130-W7B5F0BB94C76AF6B12EA7B91C0@phx.gbl>
  2015-11-19  0:11 ` [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Russell King - ARM Linux
  2015-11-19  6:14 ` Vineet Gupta
@ 2015-11-19 11:25 ` Arnd Bergmann
  2015-11-19 16:18   ` Russell King - ARM Linux
  2015-11-20 12:15 ` Greg Ungerer
  3 siblings, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2015-11-19 11:25 UTC (permalink / raw)
  To: linux-arm-kernel, linux-snps-arc@lists.infradead.org
  Cc: Chen Gang, vgupta@synopsys.com, dhowells@redhat.com,
	linux@arm.linux.org.uk, geert@linux-m68k.org, gerg@uclinux.org,
	jonas@southpole.se, abrodkin@synopsys.com, Andrew Morton,
	linux-arch@vger.kernel.org, kernel mailing list,
	linux-m68k@lists.linux-m68k.org

On Thursday 19 November 2015 03:40:25 Chen Gang wrote:
> diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h
> index 37d1fe2..67cfb7d 100644
> --- a/include/asm-generic/page.h
> +++ b/include/asm-generic/page.h
> @@ -24,9 +24,6 @@
>  
>  #ifndef __ASSEMBLY__
>  
> -#define get_user_page(vaddr)           __get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)     free_page(addr)
> -
>  #define clear_page(page)       memset((page), 0, PAGE_SIZE)
>  #define copy_page(to,from)     memcpy((to), (from), PAGE_SIZE)
>  
> 

Looks good. I can take the asm-generic portion when you split it up, and
I can also help you merge the remaining patches in case some of
the arch maintainers fail to pick them up. I think all five of them
are actively maintained though, so the patches should just go through
the respective architecture trees.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
  2015-11-19 11:25 ` Arnd Bergmann
@ 2015-11-19 16:18   ` Russell King - ARM Linux
  2015-11-19 16:35     ` Arnd Bergmann
  0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2015-11-19 16:18 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: linux-arm-kernel, linux-snps-arc@lists.infradead.org, Chen Gang,
	vgupta@synopsys.com, dhowells@redhat.com, geert@linux-m68k.org,
	gerg@uclinux.org, jonas@southpole.se, abrodkin@synopsys.com,
	Andrew Morton, linux-arch@vger.kernel.org, kernel mailing list,
	linux-m68k@lists.linux-m68k.org

On Thu, Nov 19, 2015 at 12:25:45PM +0100, Arnd Bergmann wrote:
> On Thursday 19 November 2015 03:40:25 Chen Gang wrote:
> > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h
> > index 37d1fe2..67cfb7d 100644
> > --- a/include/asm-generic/page.h
> > +++ b/include/asm-generic/page.h
> > @@ -24,9 +24,6 @@
> >  
> >  #ifndef __ASSEMBLY__
> >  
> > -#define get_user_page(vaddr)           __get_free_page(GFP_KERNEL)
> > -#define free_user_page(page, addr)     free_page(addr)
> > -
> >  #define clear_page(page)       memset((page), 0, PAGE_SIZE)
> >  #define copy_page(to,from)     memcpy((to), (from), PAGE_SIZE)
> >  
> > 
> 
> Looks good. I can take the asm-generic portion when you split it up, and
> I can also help you merge the remaining patches in case some of
> the arch maintainers fail to pick them up. I think all five of them
> are actively maintained though, so the patches should just go through
> the respective architecture trees.

Or we just ack the patch and have it go through one tree, which I think
is the most sensible.  I can't imagine that there would be any major
conflicts here, surely no one is constantly changing their asm/page.h ?

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
  2015-11-19 16:18   ` Russell King - ARM Linux
@ 2015-11-19 16:35     ` Arnd Bergmann
  0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-11-19 16:35 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: linux-arm-kernel, linux-snps-arc@lists.infradead.org, Chen Gang,
	vgupta@synopsys.com, dhowells@redhat.com, geert@linux-m68k.org,
	gerg@uclinux.org, jonas@southpole.se, abrodkin@synopsys.com,
	Andrew Morton, linux-arch@vger.kernel.org, kernel mailing list,
	linux-m68k@lists.linux-m68k.org

On Thursday 19 November 2015 16:18:43 Russell King - ARM Linux wrote:
> On Thu, Nov 19, 2015 at 12:25:45PM +0100, Arnd Bergmann wrote:
> > On Thursday 19 November 2015 03:40:25 Chen Gang wrote:
> > > diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h
> > > index 37d1fe2..67cfb7d 100644
> > > --- a/include/asm-generic/page.h
> > > +++ b/include/asm-generic/page.h
> > > @@ -24,9 +24,6 @@
> > >  
> > >  #ifndef __ASSEMBLY__
> > >  
> > > -#define get_user_page(vaddr)           __get_free_page(GFP_KERNEL)
> > > -#define free_user_page(page, addr)     free_page(addr)
> > > -
> > >  #define clear_page(page)       memset((page), 0, PAGE_SIZE)
> > >  #define copy_page(to,from)     memcpy((to), (from), PAGE_SIZE)
> > >  
> > > 
> > 
> > Looks good. I can take the asm-generic portion when you split it up, and
> > I can also help you merge the remaining patches in case some of
> > the arch maintainers fail to pick them up. I think all five of them
> > are actively maintained though, so the patches should just go through
> > the respective architecture trees.
> 
> Or we just ack the patch and have it go through one tree, which I think
> is the most sensible.  I can't imagine that there would be any major
> conflicts here, surely no one is constantly changing their asm/page.h ?

Yes, good point, there is really very little potential for conflicts
here. I've applied it into my asm-generic tree for now, but will
revert it if we get regressions or NAKs.

For some reason, the patch was whitespace broken, but I managed to
extract it from the attachment.

	Arnd

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
       [not found] <COL130-W7B5F0BB94C76AF6B12EA7B91C0@phx.gbl>
                   ` (2 preceding siblings ...)
  2015-11-19 11:25 ` Arnd Bergmann
@ 2015-11-20 12:15 ` Greg Ungerer
  3 siblings, 0 replies; 6+ messages in thread
From: Greg Ungerer @ 2015-11-20 12:15 UTC (permalink / raw)
  To: Chen Gang, vgupta@synopsys.com, dhowells@redhat.com,
	linux@arm.linux.org.uk, geert@linux-m68k.org, jonas@southpole.se,
	Arnd Bergmann, abrodkin@synopsys.com, Andrew Morton
  Cc: linux-snps-arc@lists.infradead.org, kernel mailing list,
	linux-arm-kernel@lists.infradead.org,
	linux-m68k@lists.linux-m68k.org, linux-arch@vger.kernel.org,
	linux

Hi Chen,

On 19/11/15 05:40, Chen Gang wrote:
>>From ba7c00c4cb976109b6a35812ce9649aaeda81e2d Mon Sep 17 00:00:00 2001
> From: Chen Gang <gang.chen.5i5j@gmail.com>
> Date: Thu, 19 Nov 2015 03:24:42 +0800
> Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
>
> They are not symmetric with each other, neither are used in real world
> (can not be found by grep command in source code root directory), so
> remove them.
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>

Compile and run tested on m68k (MMU and noMMU) targets.
No problems found. So for those parts:

Acked-by: Greg Ungerer <gerg@uclinux.org>

Regards
Greg


> ---
>   arch/arc/include/asm/page.h       | 3 ---
>   arch/arm/include/asm/page-nommu.h | 3 ---
>   arch/frv/include/asm/page.h       | 3 ---
>   arch/m68k/include/asm/page_mm.h   | 3 ---
>   arch/m68k/include/asm/page_no.h   | 3 ---
>   arch/openrisc/include/asm/page.h  | 3 ---
>   include/asm-generic/page.h        | 3 ---
>   7 files changed, 21 deletions(-)
>
> diff --git a/arch/arc/include/asm/page.h b/arch/arc/include/asm/page.h
> index 429957f..adf5cbb 100644
> --- a/arch/arc/include/asm/page.h
> +++ b/arch/arc/include/asm/page.h
> @@ -13,9 +13,6 @@
>
>   #ifndef __ASSEMBLY__
>
> -#define get_user_page(vaddr)		__get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)	free_page(addr)
> -
>   #define clear_page(paddr)		memset((paddr), 0, PAGE_SIZE)
>   #define copy_page(to, from)		memcpy((to), (from), PAGE_SIZE)
>
> diff --git a/arch/arm/include/asm/page-nommu.h b/arch/arm/include/asm/page-nommu.h
> index d1b162a..503f488 100644
> --- a/arch/arm/include/asm/page-nommu.h
> +++ b/arch/arm/include/asm/page-nommu.h
> @@ -17,9 +17,6 @@
>   #define KTHREAD_SIZE PAGE_SIZE
>   #endif
>
> -#define get_user_page(vaddr)		__get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)	free_page(addr)
> -
>   #define clear_page(page)	memset((page), 0, PAGE_SIZE)
>   #define copy_page(to,from)	memcpy((to), (from), PAGE_SIZE)
>
> diff --git a/arch/frv/include/asm/page.h b/arch/frv/include/asm/page.h
> index 8c97068..52ace96 100644
> --- a/arch/frv/include/asm/page.h
> +++ b/arch/frv/include/asm/page.h
> @@ -8,9 +8,6 @@
>
>   #ifndef __ASSEMBLY__
>
> -#define get_user_page(vaddr)			__get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)		free_page(addr)
> -
>   #define clear_page(pgaddr)			memset((pgaddr), 0, PAGE_SIZE)
>   #define copy_page(to,from)			memcpy((to), (from), PAGE_SIZE)
>
> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
> index 5029f73..e7a1946 100644
> --- a/arch/m68k/include/asm/page_mm.h
> +++ b/arch/m68k/include/asm/page_mm.h
> @@ -6,9 +6,6 @@
>   #include <linux/compiler.h>
>   #include <asm/module.h>
>
> -#define get_user_page(vaddr)		__get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)	free_page(addr)
> -
>   /*
>    * We don't need to check for alignment etc.
>    */
> diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h
> index ef20916..fa7f32d 100644
> --- a/arch/m68k/include/asm/page_no.h
> +++ b/arch/m68k/include/asm/page_no.h
> @@ -6,9 +6,6 @@
>   extern unsigned long memory_start;
>   extern unsigned long memory_end;
>
> -#define get_user_page(vaddr)		__get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)	free_page(addr)
> -
>   #define clear_page(page)	memset((page), 0, PAGE_SIZE)
>   #define copy_page(to,from)	memcpy((to), (from), PAGE_SIZE)
>
> diff --git a/arch/openrisc/include/asm/page.h b/arch/openrisc/include/asm/page.h
> index 108906f..e613d36 100644
> --- a/arch/openrisc/include/asm/page.h
> +++ b/arch/openrisc/include/asm/page.h
> @@ -40,9 +40,6 @@
>
>   #ifndef __ASSEMBLY__
>
> -#define get_user_page(vaddr)            __get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)      free_page(addr)
> -
>   #define clear_page(page)	memset((page), 0, PAGE_SIZE)
>   #define copy_page(to, from)	memcpy((to), (from), PAGE_SIZE)
>
> diff --git a/include/asm-generic/page.h b/include/asm-generic/page.h
> index 37d1fe2..67cfb7d 100644
> --- a/include/asm-generic/page.h
> +++ b/include/asm-generic/page.h
> @@ -24,9 +24,6 @@
>
>   #ifndef __ASSEMBLY__
>
> -#define get_user_page(vaddr)		__get_free_page(GFP_KERNEL)
> -#define free_user_page(page, addr)	free_page(addr)
> -
>   #define clear_page(page)	memset((page), 0, PAGE_SIZE)
>   #define copy_page(to,from)	memcpy((to), (from), PAGE_SIZE)
>
> --
> 1.9.3
>
>   		 	   		
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-11-20 12:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <COL130-W7B5F0BB94C76AF6B12EA7B91C0@phx.gbl>
2015-11-19  0:11 ` [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page Russell King - ARM Linux
2015-11-19  6:14 ` Vineet Gupta
2015-11-19 11:25 ` Arnd Bergmann
2015-11-19 16:18   ` Russell King - ARM Linux
2015-11-19 16:35     ` Arnd Bergmann
2015-11-20 12:15 ` Greg Ungerer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox