From: Corey Minyard <minyard@acm.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Openipmi-developer] [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver
Date: Thu, 19 Nov 2015 07:26:47 -0600 [thread overview]
Message-ID: <564DCE17.4040500@acm.org> (raw)
In-Reply-To: <1447905399-30671-1-git-send-email-k.kozlowski@samsung.com>
Ok, got it this time, queued for 4.5.
Thanks,
-corey
On 11/18/2015 09:56 PM, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
> drivers/char/ipmi/ipmi_ssif.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 90e624662257..5f1c3d08ba65 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1959,7 +1959,6 @@ MODULE_DEVICE_TABLE(i2c, ssif_id);
> static struct i2c_driver ssif_i2c_driver = {
> .class = I2C_CLASS_HWMON,
> .driver = {
> - .owner = THIS_MODULE,
> .name = DEVICE_NAME
> },
> .probe = ssif_probe,
prev parent reply other threads:[~2015-11-19 13:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 3:56 [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-11-19 13:26 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564DCE17.4040500@acm.org \
--to=minyard@acm.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox