From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758551AbbKSN0v (ORCPT ); Thu, 19 Nov 2015 08:26:51 -0500 Received: from mail-oi0-f51.google.com ([209.85.218.51]:33610 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757719AbbKSN0t (ORCPT ); Thu, 19 Nov 2015 08:26:49 -0500 Message-ID: <564DCE17.4040500@acm.org> Date: Thu, 19 Nov 2015 07:26:47 -0600 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [Openipmi-developer] [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver References: <1447905399-30671-1-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1447905399-30671-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ok, got it this time, queued for 4.5. Thanks, -corey On 11/18/2015 09:56 PM, Krzysztof Kozlowski wrote: > i2c_driver does not need to set an owner because i2c_register_driver() > will set it. > > Signed-off-by: Krzysztof Kozlowski > > --- > > The coccinelle script which generated the patch was sent here: > http://www.spinics.net/lists/kernel/msg2029903.html > --- > drivers/char/ipmi/ipmi_ssif.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 90e624662257..5f1c3d08ba65 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1959,7 +1959,6 @@ MODULE_DEVICE_TABLE(i2c, ssif_id); > static struct i2c_driver ssif_i2c_driver = { > .class = I2C_CLASS_HWMON, > .driver = { > - .owner = THIS_MODULE, > .name = DEVICE_NAME > }, > .probe = ssif_probe,