From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933253AbbKSNa7 (ORCPT ); Thu, 19 Nov 2015 08:30:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:53260 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755826AbbKSNa5 (ORCPT ); Thu, 19 Nov 2015 08:30:57 -0500 Message-ID: <564DCF0F.6030601@suse.de> Date: Thu, 19 Nov 2015 14:30:55 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/71] ncr5380: Split NCR5380_init() into two functions References: <20151118083455.331768508@telegraphics.com.au> <20151118083457.131801599@telegraphics.com.au> In-Reply-To: <20151118083457.131801599@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 09:35 AM, Finn Thain wrote: > This patch splits the NCR5380_init() function into two parts, similar > to the scheme used with atari_NCR5380.c. This avoids two problems. > > Firstly, NCR5380_init() may perform a bus reset, which would cause the > chip to assert IRQ. The chip is unable to mask its bus reset interrupt. > Drivers can't call request_irq() before calling NCR5380_init(), because > initialization must happen before the interrupt handler executes. If > driver initialization causes an interrupt it may be problematic on some > platforms. To avoid that, first move the bus reset code into > NCR5380_maybe_reset_bus(). > > Secondly, NCR5380_init() contains some board-specific interrupt setup code > for the NCR53C400 that does not belong in the core driver. In moving this > code, better not re-order interrupt initialization and bus reset. Again, > the solution is to move the bus reset code into NCR5380_maybe_reset_bus(). > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)