From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933925AbbKSNb6 (ORCPT ); Thu, 19 Nov 2015 08:31:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:53351 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932745AbbKSNbz (ORCPT ); Thu, 19 Nov 2015 08:31:55 -0500 Message-ID: <564DCF48.1000103@suse.de> Date: Thu, 19 Nov 2015 14:31:52 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/71] ncr5380: Move NCR53C400-specific code References: <20151118083455.331768508@telegraphics.com.au> <20151118083457.371688319@telegraphics.com.au> In-Reply-To: <20151118083457.371688319@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 09:35 AM, Finn Thain wrote: > Move board-specific code like this, > NCR5380_write(C400_CONTROL_STATUS_REG, CSR_BASE); > from the core driver to the board driver. Eliminate the NCR53C400 macro > from the core driver. Removal of all macros like this one will be > necessary in order to have one core driver that can support all kinds of > boards. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 18 ------------------ > drivers/scsi/g_NCR5380.c | 23 ++++++++++++++++++----- > drivers/scsi/g_NCR5380.h | 6 ++---- > 3 files changed, 20 insertions(+), 27 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)