From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934337AbbKSOO7 (ORCPT ); Thu, 19 Nov 2015 09:14:59 -0500 Received: from mx2.suse.de ([195.135.220.15]:57420 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934234AbbKSOO5 (ORCPT ); Thu, 19 Nov 2015 09:14:57 -0500 Message-ID: <564DD95F.2050906@suse.de> Date: Thu, 19 Nov 2015 15:14:55 +0100 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Finn Thain , "James E.J. Bottomley" , Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/71] ncr5380: Use return instead of goto in NCR5380_select() References: <20151118083455.331768508@telegraphics.com.au> <20151118083459.021681450@telegraphics.com.au> In-Reply-To: <20151118083459.021681450@telegraphics.com.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/18/2015 09:35 AM, Finn Thain wrote: > The "failed" label in NCR5380_select() is not helpful. Some failures > return 0, others -1. Use return instead of goto to improve clarity and > brevity, like atari_NCR5380.c does. Fix the relevant comments. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c | 30 ++++++++---------------------- > drivers/scsi/atari_NCR5380.c | 6 +++--- > 2 files changed, 11 insertions(+), 25 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)