From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161615AbbKSUvn (ORCPT ); Thu, 19 Nov 2015 15:51:43 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:35764 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934511AbbKSUvl (ORCPT ); Thu, 19 Nov 2015 15:51:41 -0500 Subject: Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent. To: David Daney , netdev@vger.kernel.org, "David S. Miller" , linux-kernel@vger.kernel.org, Florian Fainelli References: <1440198963-20080-1-git-send-email-ddaney.cavm@gmail.com> Cc: David Daney , Lennert Buytenhek , Grant Likely From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <564E3659.1040709@cogentembedded.com> Date: Thu, 19 Nov 2015 23:51:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1440198963-20080-1-git-send-email-ddaney.cavm@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 08/22/2015 02:16 AM, David Daney wrote: > From: David Daney > > commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent") > changed the parent of PHY devices from the bus to the bus parent. > > Then, commit 4dea547fef1b ("phylib: rework to prepare for OF > registration of PHYs") moved the code into phy_device.c > > At this point, it is somewhat unclear why the change was seen as > necessary. But, when we look at the device model tree in > /sys/devices, it is clearly incorrect. The PHYs should be children of > their MDIO bus. > > Change the PHY's parent device to be the MDIO bus device. > > Cc: Lennert Buytenhek > Cc: Grant Likely > Signed-off-by: David Daney > --- > drivers/net/phy/phy_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 0302483..55f0178 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -176,7 +176,7 @@ struct phy_device *phy_device_create(struct mii_bus *bus, int addr, int phy_id, > if (c45_ids) > dev->c45_ids = *c45_ids; > dev->bus = bus; > - dev->dev.parent = bus->parent; > + dev->dev.parent = &bus->dev; > dev->dev.bus = &mdio_bus_type; > dev->irq = bus->irq != NULL ? bus->irq[addr] : PHY_POLL; > dev_set_name(&dev->dev, PHY_ID_FMT, bus->id, addr); This patch makes my sh_eth driver fail to connect to PHY usinjg of_phy_connect(). (The ravb driver fails too but for some other reason.) MBR, Sergei