From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>,
pbonzini@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mtosatti@redhat.com
Subject: Re: [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work
Date: Fri, 20 Nov 2015 17:35:14 +0800 [thread overview]
Message-ID: <564EE952.8070305@linux.intel.com> (raw)
In-Reply-To: <20151120174005.9880b89f54eee2cec2422da5@lab.ntt.co.jp>
On 11/20/2015 04:40 PM, Takuya Yoshikawa wrote:
> It seems like you all are busy now, so I've made this patch set so that
> mechanical and trivial changes come before.
>
> V2->V3:
> Patch 01: Rebased and moved here. Updated stale comments.
> We may also want to use a union, inside the struct, to eliminate casting to
> (u64 *) type when spte is in the head in the future.
> Patch 02-05: No change.
> About patch 03: There was a comment on the usage of braces for a single line
> else-if statement from Xiao. As I answered, checkpatch did not complain about
> this, and when the corresponding if block has multiple lines, some developers
> prefer/recommend this style. Feel free to modify it if you don't like it.
> Patch 06: Changed WARN_ON to BUG_ON as Marcelo suggested.
> Patch 07: Removed unnecessary zero-initialization of sp->parent_ptes as Xiao
> suggested.
>
For patch 01 - patch 07:
Reviewed-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
next prev parent reply other threads:[~2015-11-20 9:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 8:40 [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work Takuya Yoshikawa
2015-11-20 8:41 ` [PATCH 01/10] KVM: x86: MMU: Encapsulate the type of rmap-chain head in a new struct Takuya Yoshikawa
2015-11-20 8:42 ` [PATCH 02/10] KVM: x86: MMU: Remove unused parameter of __direct_map() Takuya Yoshikawa
2015-11-20 8:43 ` [PATCH 03/10] KVM: x86: MMU: Add helper function to clear a bit in unsync child bitmap Takuya Yoshikawa
2015-11-20 8:44 ` [PATCH 04/10] KVM: x86: MMU: Make mmu_set_spte() return emulate value Takuya Yoshikawa
2015-11-20 8:44 ` [PATCH 05/10] KVM: x86: MMU: Remove is_rmap_spte() and use is_shadow_present_pte() Takuya Yoshikawa
2015-11-20 8:45 ` [PATCH 06/10] KVM: x86: MMU: Consolidate BUG_ON checks for reverse-mapped sptes Takuya Yoshikawa
2015-11-20 8:46 ` [PATCH 07/10] KVM: x86: MMU: Move initialization of parent_ptes out from kvm_mmu_alloc_page() Takuya Yoshikawa
2015-11-20 8:47 ` [PATCH 08/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead of pte_list_walk() Takuya Yoshikawa
2015-11-20 8:46 ` Xiao Guangrong
2015-11-20 9:08 ` Takuya Yoshikawa
2015-11-25 16:29 ` Paolo Bonzini
2015-11-20 8:48 ` [PATCH 09/10] KVM: x86: MMU: Move parent_pte handling from kvm_mmu_get_page() to link_shadow_page() Takuya Yoshikawa
2015-11-20 8:57 ` Xiao Guangrong
2015-11-25 16:32 ` Paolo Bonzini
2015-11-26 2:36 ` Takuya Yoshikawa
2015-11-20 8:48 ` [PATCH 10/10] KVM: x86: MMU: Remove unused parameter parent_pte from kvm_mmu_get_page() Takuya Yoshikawa
2015-11-20 9:35 ` Xiao Guangrong [this message]
2015-11-20 16:01 ` [PATCH V3 00/10] KVM: x86: MMU: Clean up x86's mmu code for future work Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564EE952.8070305@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox