Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Måns Rullgård
2015-11-25T12:12:45Z

Mason <slash.tmp@free.fr> writes:

>> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS);
>> + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS);
>
> In my local branch, I wrote:
>
> #define IRQ_CTL_LO 0
>
> status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS);
> status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS);
>
> (I'm a sucker for symmetry)

Nothing wrong with a little symmetry, though in this case I think the
extra macro only confuses matters.

--
Måns Rullgård
mans@mansr.com