Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Måns Rullgård
2015-11-25T12:11:20Z

Mason <slash.tmp@free.fr> writes:

> [ Trimming CC list ]
>
> On 19/11/2015 19:33, Mans Rullgard wrote:
>
>> +config TANGOX_IRQ
>
> Could you drop the X?

Sure, if that's what people prefer.

> (And perhaps change IRQ to IRQCHIP? What's the current trend?)

Most of the existing entries say just IRQ or something completely ad
hoc, only 4 IRQCHIP.

>> + bool
>> + select IRQ_DOMAIN
>> + select GENERIC_IRQ_CHIP
>
> Could you sort alphabetically, like the mach Kconfig?

Tell that to all the other ones. Oh well, whatever.

--
Måns Rullgård
mans@mansr.com