public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak
Date: Fri, 20 Nov 2015 12:33:50 +0100	[thread overview]
Message-ID: <564F051E.9010703@profitbricks.com> (raw)
In-Reply-To: <564EFF6A.2050709@profitbricks.com>

The kmemleak testing on 3.18.24 show:

unreferenced object 0xffff880233ff9010 (size 16):
  comm "swapper/0", pid 1, jiffies 4294937440 (age 2010.490s)
  hex dump (first 16 bytes):
    0a 0a 00 00 20 00 00 00 00 44 fb 33 02 88 ff ff  .... ....D.3....
  backtrace:
    [<ffffffff8118192d>] create_object+0x10d/0x2d0
    [<ffffffff815c2d4b>] kmemleak_alloc+0x5b/0xc0
    [<ffffffff8116dd19>] kmem_cache_alloc_trace+0xb9/0x160
    [<ffffffff814ffe51>] get_irq_table+0x151/0x380

This is caused by the 'irq_lookup_table' was allocated with
__get_free_pages() which won't create kmemleak object, thus it's
pointers won't be count as referencing 'irq_remap_table' in
kmemleak scan.

The 'irq_remap_table' won't be freed after initialized, doesn't
make sense to check it's leaking.

This patch mark the 'irq_remap_table' object as 'gray' to stop
the 'false positives' report.

Signed-off-by: Michael Wang <yun.wang@profitbricks.com>
---
v2:
  Use kmemleak_not_leak() instead of kmemleak_ignore() since
  the 'irq_remap_table' itself also contain pointer.

 drivers/iommu/amd_iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 8b2be1e..87a1a88 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3603,6 +3603,7 @@ static struct irq_remap_table *get_irq_table(u16 devid, bool ioapic)
 	}
 
 	irq_lookup_table[devid] = table;
+	kmemleak_not_leak(table);
 	set_dte_irq_entry(devid, table);
 	iommu_flush_dte(iommu, devid);
 	if (devid != alias) {
-- 
2.1.4


  reply	other threads:[~2015-11-20 11:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 11:09 [RFC PATCH] iommu/amd: make kmemleak ignore the 'irq_remap_table' object Michael Wang
2015-11-20 11:33 ` Michael Wang [this message]
2015-11-20 12:31   ` [RFC PATCH v2] iommu/amd: gray the 'irq_remap_table' object for kmemleak Michael Wang
2015-11-25 11:14   ` Michael Wang
2015-11-25 15:08   ` Joerg Roedel
2015-11-25 15:14     ` Michael Wang
2015-12-02 10:37       ` Michael Wang
2015-12-02 10:52         ` Catalin Marinas
2015-12-02 10:56           ` Michael Wang
2015-12-02 11:31             ` Catalin Marinas
2015-12-02 11:38               ` Michael Wang
2015-12-02 11:51                 ` Joerg Roedel
2015-12-02 12:31                   ` Michael Wang
2015-12-02 12:53                     ` Borislav Petkov
2015-12-02 13:01                       ` Michael Wang
2015-12-02 13:13                         ` Borislav Petkov
2015-12-02 13:18                           ` Michael Wang
2015-12-02 13:40                             ` Borislav Petkov
2015-12-02 13:48                               ` Michael Wang
2015-12-02 13:59                                 ` Borislav Petkov
2015-12-02 14:09                                   ` Michael Wang
2015-12-02 14:13                                     ` Borislav Petkov
2015-12-02 14:21                                       ` Michael Wang
2015-12-02 17:36                                   ` Catalin Marinas
2015-12-02 18:40                                     ` Borislav Petkov
2015-12-03  8:47                                     ` Michael Wang
2015-12-02 12:56                     ` Joerg Roedel
2015-12-02 13:07                       ` Michael Wang
2015-12-02 11:17           ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564F051E.9010703@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox