From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752093AbbKVMGq (ORCPT ); Sun, 22 Nov 2015 07:06:46 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:45038 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269AbbKVMGp (ORCPT ); Sun, 22 Nov 2015 07:06:45 -0500 Subject: Re: [PATCH] IIO: adc: at91_adc.c Prefer kmalloc_array over kmalloc with multiply To: Nizam Haider References: <1447632357-8222-1-git-send-email-nizamhaider786@gmail.com> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, leupold@rsi-elektrotechnik.de, nicolas.ferre@atmel.com, alexandre.belloni@free-electrons.com, octavian.purdila@intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <5651AFD0.8060905@kernel.org> Date: Sun, 22 Nov 2015 12:06:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447632357-8222-1-git-send-email-nizamhaider786@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/11/15 00:05, Nizam Haider wrote: > So this patch swaps that use out for kmalloc_array instead. > > Signed-off-by Nizam Haider Applied to the togreg branch of iio.git - initially push out as staging Thanks, Jonathan > --- > drivers/iio/adc/at91_adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7b40925..f284cd6 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -742,7 +742,7 @@ static int at91_adc_of_get_resolution(struct at91_adc_state *st, > return count; > } > > - resolutions = kmalloc(count * sizeof(*resolutions), GFP_KERNEL); > + resolutions = kmalloc_array(count, sizeof(*resolutions), GFP_KERNEL); > if (!resolutions) > return -ENOMEM; > >