From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753207AbbKWCbo (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 Nov 2015 21:31:44 -0500
Received: from smtp.codeaurora.org ([198.145.29.96]:44259 "EHLO
	smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753131AbbKWCbm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 Nov 2015 21:31:42 -0500
Subject: Re: [PATCH V6 2/3] dma: add Qualcomm Technologies HIDMA management
 driver
To: Andy Shevchenko <andy.shevchenko@gmail.com>
References: <1448210257-4768-1-git-send-email-okaya@codeaurora.org>
 <1448210257-4768-3-git-send-email-okaya@codeaurora.org>
 <CAHp75Vc72HLbNdPKXzm=RqsFZS1cmAVuH3Nd6yO+TJidLeuExg@mail.gmail.com>
 <565bdce834ba1cf4a73029b5c027856e.squirrel@www.codeaurora.org>
 <CAHp75VdAdrbQv1EY+KDsoAbyGURxfr+3c5f=-w=OR4MhBoWDHA@mail.gmail.com>
Cc: dmaengine <dmaengine@vger.kernel.org>, Timur Tabi <timur@codeaurora.org>,
        cov@codeaurora.org, jcm@redhat.com, Andy Gross <agross@codeaurora.org>,
        Arnd Bergmann <arnd@arndb.de>, linux-arm-msm@vger.kernel.org,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Sinan Kaya <okaya@codeaurora.org>
Message-ID: <56527A87.80201@codeaurora.org>
Date: Sun, 22 Nov 2015 21:31:35 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CAHp75VdAdrbQv1EY+KDsoAbyGURxfr+3c5f=-w=OR4MhBoWDHA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>
>>> Can it be like
>>>
>>> /sys/…/DEVICExx/
>>>  channelYY/
>>>  attr1
>>>  attr2
>>>  …
>>>
>>> ?
>>
>> I'll work on it. I didn't know that you are allowed to create subdirectories
>> in sysfs. I was just creating attributes to keep it simple. But, your
>> suggestion is cleaner.
>>
>>>
>>> I think it will be easier to handle in code and from user. (Similar
>>> way DMAEngine API does for slave DMA devices)
>>
>> Now, the good stuff. Can you clarify your comment? I didn't understand it.
> 
> I meant that DMAEngine uses
> /sys/class/dma
>  dmaYchannelX/
>   attr1
>   attr2
>   …
> 
> layout.
> 

I have posted v7 with this change.


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project