From: Daniel Wagner <daniel.wagner@bmw-carit.de>
To: Tejun Heo <tj@kernel.org>, <davem@davemloft.net>,
<pablo@netfilter.org>, <kaber@trash.net>,
<kadlec@blackhole.kfki.hu>, <daniel@iogearbox.net>,
<nhorman@tuxdriver.co>
Cc: <lizefan@huawei.com>, <hannes@cmpxchg.org>,
<netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
<coreteam@netfilter.org>, <cgroups@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
<ninasc@fb.com>
Subject: Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup
Date: Mon, 23 Nov 2015 09:54:32 +0100 [thread overview]
Message-ID: <5652D448.3080002@bmw-carit.de> (raw)
In-Reply-To: <5652BC3A.1010701@bmw-carit.de>
On 11/23/2015 08:11 AM, Daniel Wagner wrote:
> [ 3.217648] systemd[1]: tmp.mount: Directory /tmp to mount over is not empty, mounting anyway.
> [ 3.224665] BUG: spinlock bad magic on CPU#1, systemd/1
> [ 3.225653] lock: cgroup_sk_update_lock+0x0/0x60, .magic: 00000000, .owner: systemd/1, .owner_cpu: 1
> [ 3.227034] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #195
> [ 3.227862] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014
> [ 3.228906] ffffffff834a2160 ffff88007c043ad0 ffffffff81551edc ffff88007c028000
> [ 3.229512] ffff88007c043af0 ffffffff81136868 ffffffff834a2160 ffff88007aff5940
> [ 3.230105] ffff88007c043b08 ffffffff81136b05 ffffffff834a2160 ffff88007c043b20
> [ 3.230716] Call Trace:
> [ 3.230906] [<ffffffff81551edc>] dump_stack+0x4e/0x82
> [ 3.231289] [<ffffffff81136868>] spin_dump+0x78/0xc0
> [ 3.231642] [<ffffffff81136b05>] do_raw_spin_unlock+0x75/0xd0
> [ 3.232039] [<ffffffff81bced77>] _raw_spin_unlock+0x27/0x50
> [ 3.232431] [<ffffffff819b1848>] update_classid_sock+0x68/0x80
> [ 3.232836] [<ffffffff812855c1>] iterate_fd+0x71/0x150
> [ 3.233197] [<ffffffff819b1757>] update_classid+0x47/0x80
> [ 3.233571] [<ffffffff819b17d4>] cgrp_attach+0x14/0x20
> [ 3.233929] [<ffffffff81188951>] cgroup_taskset_migrate+0x1e1/0x330
> [ 3.234366] [<ffffffff81188b95>] cgroup_migrate+0xf5/0x190
> [ 3.234747] [<ffffffff81188aa5>] ? cgroup_migrate+0x5/0x190
> [ 3.235130] [<ffffffff81188da6>] cgroup_attach_task+0x176/0x200
> [ 3.235543] [<ffffffff81188c35>] ? cgroup_attach_task+0x5/0x200
> [ 3.235953] [<ffffffff8118922d>] __cgroup_procs_write+0x2ad/0x460
> [ 3.236377] [<ffffffff81188fde>] ? __cgroup_procs_write+0x5e/0x460
> [ 3.236805] [<ffffffff81189414>] cgroup_procs_write+0x14/0x20
> [ 3.237205] [<ffffffff81185ae5>] cgroup_file_write+0x35/0x1c0
> [ 3.237600] [<ffffffff812e25e1>] kernfs_fop_write+0x141/0x190
> [ 3.237998] [<ffffffff81265e78>] __vfs_write+0x28/0xe0
> [ 3.238361] [<ffffffff811292c7>] ? percpu_down_read+0x57/0xa0
> [ 3.238761] [<ffffffff81268b04>] ? __sb_start_write+0xb4/0xf0
> [ 3.239154] [<ffffffff81268b04>] ? __sb_start_write+0xb4/0xf0
> [ 3.239554] [<ffffffff812665ec>] vfs_write+0xac/0x1a0
> [ 3.239930] [<ffffffff81285fa6>] ? __fget_light+0x66/0x90
> [ 3.240308] [<ffffffff81266f09>] SyS_write+0x49/0xb0
> [ 3.240656] [<ffffffff81bcfb32>] entry_SYSCALL_64_fastpath+0x12/0x76
I have enabled a few additional cgroup controllers as well, because I was
trying to figure out why I only see the 'memory' cgroup controller in
cgroup.controllers. pid and io show up but not net_prio or net_cls.
Not sure why systemd (v227) is not mounting them.
Though, after a while a similar call trace is produced. I guess this
has nothing to do with the current changes.
[ 11.594536] ------------[ cut here ]------------
[ 11.595274] WARNING: CPU: 1 PID: 1 at kernel/cgroup_pids.c:97 pids_cancel.constprop.6+0x31/0x40()
[ 11.595958] Modules linked in:
[ 11.596199] CPU: 1 PID: 1 Comm: systemd Not tainted 4.4.0-rc1+ #196
[ 11.596689] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.8.2-0-g33fbe13 by qemu-project.org 04/01/2014
[ 11.597632] ffffffff81f66d8b ffff88007c04bb90 ffffffff8155ccdc 0000000000000000
[ 11.598234] ffff88007c04bbc8 ffffffff810de202 ffff8800793dda00 ffff88007a096800
[ 11.598877] ffff88007c04bc80 ffff88007a6b6200 0000000000000001 ffff88007c04bbd8
[ 11.599547] Call Trace:
[ 11.599784] [<ffffffff8155ccdc>] dump_stack+0x4e/0x82
[ 11.600197] [<ffffffff810de202>] warn_slowpath_common+0x82/0xc0
[ 11.600705] [<ffffffff810de2fa>] warn_slowpath_null+0x1a/0x20
[ 11.601208] [<ffffffff8118e261>] pids_cancel.constprop.6+0x31/0x40
[ 11.601764] [<ffffffff8118e32d>] pids_can_attach+0x6d/0xf0
[ 11.602245] [<ffffffff811887fa>] cgroup_taskset_migrate+0x6a/0x330
[ 11.602795] [<ffffffff81188bb5>] cgroup_migrate+0xf5/0x190
[ 11.603276] [<ffffffff81188ac5>] ? cgroup_migrate+0x5/0x190
[ 11.603788] [<ffffffff81188dc6>] cgroup_attach_task+0x176/0x200
[ 11.604308] [<ffffffff81188c55>] ? cgroup_attach_task+0x5/0x200
[ 11.604831] [<ffffffff8118924d>] __cgroup_procs_write+0x2ad/0x460
[ 11.605367] [<ffffffff81188ffe>] ? __cgroup_procs_write+0x5e/0x460
[ 11.605929] [<ffffffff81189434>] cgroup_procs_write+0x14/0x20
[ 11.606448] [<ffffffff81185af5>] cgroup_file_write+0x35/0x1c0
[ 11.606931] [<ffffffff812e94f1>] kernfs_fop_write+0x141/0x190
[ 11.607401] [<ffffffff81269b18>] __vfs_write+0x28/0xe0
[ 11.607834] [<ffffffff811292d7>] ? percpu_down_read+0x57/0xa0
[ 11.608366] [<ffffffff8126c7a4>] ? __sb_start_write+0xb4/0xf0
[ 11.608874] [<ffffffff8126c7a4>] ? __sb_start_write+0xb4/0xf0
[ 11.609343] [<ffffffff8126a28c>] vfs_write+0xac/0x1a0
[ 11.609843] [<ffffffff81289db6>] ? __fget_light+0x66/0x90
[ 11.610315] [<ffffffff8126aba9>] SyS_write+0x49/0xb0
[ 11.610756] [<ffffffff81bdb4f2>] entry_SYSCALL_64_fastpath+0x12/0x76
[ 11.611305] ---[ end trace 7f953d0ce5af99ea ]---
next prev parent reply other threads:[~2015-11-23 8:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 16:13 [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:13 ` [PATCH 1/9] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo
2015-11-21 16:13 ` [PATCH 2/9] kernfs: implement kernfs_walk_and_get() Tejun Heo
2015-11-21 16:13 ` [PATCH 3/9] cgroup: implement cgroup_get_from_path() and expose cgroup_put() Tejun Heo
2015-11-21 16:13 ` [PATCH 4/9] cgroups: Allow dynamically changing net_classid Tejun Heo
2015-11-21 16:13 ` [PATCH 5/9] netprio_cgroup: limit the maximum css->id to USHRT_MAX Tejun Heo
2015-11-21 16:13 ` [PATCH 6/9] net: wrap sock->sk_cgrp_prioidx and ->sk_classid inside a struct Tejun Heo
2015-11-21 16:13 ` [PATCH 7/9] sock, cgroup: add sock->sk_cgroup Tejun Heo
2015-11-23 13:02 ` Daniel Wagner
2015-11-23 15:48 ` Tejun Heo
2015-11-23 15:53 ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 8/9] netfilter: prepare xt_cgroup for multi revisions Tejun Heo
2015-11-23 12:44 ` Daniel Wagner
2015-11-21 16:14 ` [PATCH 9/9] netfilter: implement xt_cgroup cgroup2 path match Tejun Heo
2015-11-21 16:56 ` Florian Westphal
2015-11-21 17:04 ` Tejun Heo
2015-11-21 18:54 ` Florian Westphal
2015-11-21 20:26 ` Jan Engelhardt
2015-11-23 13:43 ` Daniel Borkmann
2015-11-23 13:51 ` Daniel Borkmann
2015-11-23 15:40 ` Tejun Heo
2015-11-23 17:35 ` David Laight
2015-11-23 17:55 ` Jan Engelhardt
2015-11-23 12:43 ` Daniel Wagner
2015-11-23 15:41 ` Tejun Heo
2015-11-21 16:17 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo
2015-11-21 16:18 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Tejun Heo
2015-11-21 16:19 ` [PATCH 2/2 iptables] libxt_cgroup: add support for cgroup2 path matching Tejun Heo
2015-11-22 20:31 ` [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Pablo Neira Ayuso
2015-11-22 20:34 ` Pablo Neira Ayuso
2015-11-23 7:11 ` [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Daniel Wagner
2015-11-23 8:54 ` Daniel Wagner [this message]
2015-11-23 15:53 ` Tejun Heo
2015-11-23 15:57 ` Daniel Wagner
2015-11-23 19:58 ` Tejun Heo
2015-11-23 20:45 ` David Miller
2015-11-23 20:54 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652D448.3080002@bmw-carit.de \
--to=daniel.wagner@bmw-carit.de \
--cc=cgroups@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hannes@cmpxchg.org \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nhorman@tuxdriver.co \
--cc=ninasc@fb.com \
--cc=pablo@netfilter.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox