From: Ian Abbott <abbotti@mev.co.uk>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jitendra Kumar Khasdev <jkhasdev@gmail.com>
Cc: hsweeten@visionengravers.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jitendra Kumar Khasdev <jitendra.khasdev@hotwaxsystems.com>
Subject: Re: [PATCH] staging: comedi: Coding style warning fix for block comments
Date: Mon, 23 Nov 2015 10:27:47 +0000 [thread overview]
Message-ID: <5652EA23.8000703@mev.co.uk> (raw)
In-Reply-To: <CAHp75Vd00iidhnCx-2Gz7T5cGifz0gW6_8E=L9P5PhGebwrwpA@mail.gmail.com>
On 22/11/15 19:24, Andy Shevchenko wrote:
> On Sun, Nov 22, 2015 at 9:19 PM, Jitendra Kumar Khasdev
> <jkhasdev@gmail.com> wrote:
>> This patch is to comedilib.h file that fixes up following warnings
>> reported by checkpatch.pl :
>> I) Block comments use * on subsequent lines
>>
>> Signed-off-by: Jitendra Kumar Khasdev <jkhasdev@gmail.com>
>> ---
>> drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
>> 1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
>> index 56baf85..ccbe17b 100644
>> --- a/drivers/staging/comedi/comedilib.h
>> +++ b/drivers/staging/comedi/comedilib.h
>> @@ -1,20 +1,20 @@
>> /*
>> - linux/include/comedilib.h
>
> I don't think the file name is somehow useful here.
To be fair, this patch is merely fixing the comment style, rather than
changing the contents. Although I wouldn't mind if this line were
changed, especially as the existing pathname is wrong.
It could be changed to be just the basename of the header file like this:
* comedilib.h
which is similar to the header comment in comedidev.h.
>
>
>> - header file for kcomedilib
>
> Perhaps
>
> * Header file for kcomedilib.
No objections there.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-11-23 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 19:19 [PATCH] staging: comedi: Coding style warning fix for block comments Jitendra Kumar Khasdev
2015-11-22 19:24 ` Andy Shevchenko
2015-11-23 10:27 ` Ian Abbott [this message]
2015-11-23 10:29 ` Ian Abbott
-- strict thread matches above, loose matches on Subject: below --
2015-09-20 8:50 [PATCH] Staging: " Punit Vara
2015-09-21 17:45 ` Ian Abbott
2015-09-21 17:57 ` punit vara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5652EA23.8000703@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=jitendra.khasdev@hotwaxsystems.com \
--cc=jkhasdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox