From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754278AbbKWRKX (ORCPT ); Mon, 23 Nov 2015 12:10:23 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:33757 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753421AbbKWRKV (ORCPT ); Mon, 23 Nov 2015 12:10:21 -0500 Subject: Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module To: Arnd Bergmann References: <1448297631-8916-1-git-send-email-afd@ti.com> <3809374.hKy9fQ2ldj@wuerfel> CC: =?UTF-8?Q?Pali_Roh=c3=a1r?= , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Andreas Dannenberg , , From: "Andrew F. Davis" Message-ID: <5653485E.70005@ti.com> Date: Mon, 23 Nov 2015 11:09:50 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <3809374.hKy9fQ2ldj@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/2015 10:57 AM, Arnd Bergmann wrote: > On Monday 23 November 2015 10:53:51 Andrew F. Davis wrote: >> Separate out I2C functionality into a module. This fixes several small >> issues and simplifies the driver initialization. >> >> Signed-off-by: Andrew F. Davis > > That looks good to me overall, it should help with the randconfig > warnings I've been seeing and makes the driver structured more logically. > > The one part I wonder about is whether the platform_driver portion > should also be split out into a separate module in the same way. > > Arnd > I think it should, I'm just waiting until I can find some time to bring up regmap for 1wire, then I can really clean things up and move the platform stuff (which is really the 1wire interface) out more cleanly, all I'll need to do then is just pass a regmap handle to the core from the interface modules. But that's all a project for another day :)