From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Eduardo Valentin <edubezval@gmail.com>,
Saurabh Sengar <saurabh.truth@gmail.com>
Cc: l.majewski@samsung.com, rui.zhang@intel.com, kgene@kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: exynos: use of_property_read_u8()
Date: Tue, 24 Nov 2015 10:28:25 +0900 [thread overview]
Message-ID: <5653BD39.6060406@samsung.com> (raw)
In-Reply-To: <20151123232933.GB6815@localhost.localdomain>
On 24.11.2015 08:29, Eduardo Valentin wrote:
> On Mon, Nov 23, 2015 at 07:40:41PM +0530, Saurabh Sengar wrote:
>> use of_property_read_u8() for u8 variables,
>> also changed the return type to void as this function return type
>> is nowhere used.
>>
>
> I would be good if you could split both changes into two patches.
>
> Also, I still do not understand properly the proposal to use u8.
>
> Why are they u8?
>
> If they are so, please document them in their DT bindings. Today, the
> bindings tell us they are s32 (as there is nothing really specifying the
> type).
It looks like u8 came from platform data from old times when the driver
did not support DT. All of our Exynos mainline boards are converted to
DT, so I think legacy platform data can be also changed to match DT.
Which means changing from u8 to u32.
Best regards,
Krzysztof
prev parent reply other threads:[~2015-11-24 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 14:10 [PATCH] thermal: exynos: use of_property_read_u8() Saurabh Sengar
2015-11-23 23:29 ` Eduardo Valentin
2015-11-24 1:28 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5653BD39.6060406@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=edubezval@gmail.com \
--cc=kgene@kernel.org \
--cc=l.majewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox