From: "Matias Bjørling" <m@bjorling.me>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
"ww.tao0320@gmail.com" <ww.tao0320@gmail.com>
Subject: Re: [PATCH 1/5] lightnvm: change vendor and dev id for qemu
Date: Tue, 24 Nov 2015 19:24:05 +0100 [thread overview]
Message-ID: <5654AB45.80204@bjorling.me> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295BE51C85@G9W0745.americas.hpqcorp.net>
On 11/24/2015 04:52 PM, Elliott, Robert (Persistent Memory) wrote:
>
>
>> -----Original Message-----
>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
>> owner@vger.kernel.org] On Behalf Of Matias Bjørling
>> Sent: Tuesday, November 24, 2015 7:27 AM
> ...
>> Instead of using the Intel NVMe QEMU instance vendor and device id,
>> let's use a preallocated from CNEX Labs instead. This lets us
> ...
>> /* QEMU NVMe simulator - PCI ID + Vendor specific bit */
>> - if (pdev->vendor == PCI_VENDOR_ID_INTEL && pdev->device ==
>> 0x5845 &&
>> + if (pdev->vendor == 0x1d1d && pdev->device == 0x1f1f &&
>> id->vs[0] == 0x1)
>
> Could this patch add PCI_VENDOR_ID_CNEX to the appropriate .h file
> and use that instead?
We could. But it would only be for this single use-case? Might be a
little overkill to put in pci_ids.h. Opt for lightnvm.h? or somewhere else?
Thanks
next prev parent reply other threads:[~2015-11-24 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 13:26 [PATCH 0/5] LightNVM fixes Matias Bjørling
2015-11-24 13:26 ` [PATCH 1/5] lightnvm: change vendor and dev id for qemu Matias Bjørling
2015-11-24 15:52 ` Elliott, Robert (Persistent Memory)
2015-11-24 18:24 ` Matias Bjørling [this message]
2015-11-24 22:21 ` Jens Axboe
2015-11-24 13:26 ` [PATCH 2/5] lightnvm: Simplify config when disabled Matias Bjørling
2015-11-24 13:26 ` [PATCH 3/5] lightnvm: free memory when gennvm register fails Matias Bjørling
2015-11-24 13:26 ` [PATCH 4/5] lightnvm: fix ioctl memory leaks Matias Bjørling
2015-11-24 13:26 ` [PATCH 5/5] lightnvm: do device max sectors boundary check first Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5654AB45.80204@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=elliott@hpe.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=ww.tao0320@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox