Re: [PATCH] lightnvm: missing nvm_lock acquire

kbuild test robot
2015-11-24T15:36:33Z

[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]

Hi Wenwei,

[auto build test WARNING on v4.4-rc2]
[also build test WARNING on next-20151124]

url: https://github.com/0day-ci/linux/commits/Wenwei-Tao/lightnvm-missing-nvm_lock-acquire/20151124-232858
config: x86_64-randconfig-x016-11241713 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All warnings (new ones prefixed by >>):

drivers/lightnvm/core.c: In function 'nvm_unregister':
>> drivers/lightnvm/core.c:337:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
struct nvm_dev *dev = nvm_find_nvm_dev(disk_name);
^

vim +337 drivers/lightnvm/core.c

cd9e9808 Matias Bjørling 2015-10-28 321 }
cd9e9808 Matias Bjørling 2015-10-28 322 } else if (dev->ops->max_phys_sect > 256) {
cd9e9808 Matias Bjørling 2015-10-28 323 pr_info("nvm: max sectors supported is 256.\n");
cd9e9808 Matias Bjørling 2015-10-28 324 return -EINVAL;
cd9e9808 Matias Bjørling 2015-10-28 325 }
cd9e9808 Matias Bjørling 2015-10-28 326
cd9e9808 Matias Bjørling 2015-10-28 327 return 0;
cd9e9808 Matias Bjørling 2015-10-28 328 err_init:
cd9e9808 Matias Bjørling 2015-10-28 329 kfree(dev);
cd9e9808 Matias Bjørling 2015-10-28 330 return ret;
cd9e9808 Matias Bjørling 2015-10-28 331 }
cd9e9808 Matias Bjørling 2015-10-28 332 EXPORT_SYMBOL(nvm_register);
cd9e9808 Matias Bjørling 2015-10-28 333
cd9e9808 Matias Bjørling 2015-10-28 334 void nvm_unregister(char *disk_name)
cd9e9808 Matias Bjørling 2015-10-28 335 {
0d5267d8 Wenwei Tao 2015-11-24 336 down_write(&nvm_lock);
cd9e9808 Matias Bjørling 2015-10-28 @337 struct nvm_dev *dev = nvm_find_nvm_dev(disk_name);
cd9e9808 Matias Bjørling 2015-10-28 338
cd9e9808 Matias Bjørling 2015-10-28 339 if (!dev) {
cd9e9808 Matias Bjørling 2015-10-28 340 pr_err("nvm: could not find device %s to unregister\n",
cd9e9808 Matias Bjørling 2015-10-28 341 disk_name);
0d5267d8 Wenwei Tao 2015-11-24 342 up_write(&nvm_lock);
cd9e9808 Matias Bjørling 2015-10-28 343 return;
cd9e9808 Matias Bjørling 2015-10-28 344 }
cd9e9808 Matias Bjørling 2015-10-28 345

:::::: The code at line 337 was first introduced by commit
:::::: cd9e9808d18fe7107c306f6e71c8be7230ee42b4 lightnvm: Support for Open-Channel SSDs

:::::: TO: Matias Bjørling <m@bjorling.me>
:::::: CC: Jens Axboe <axboe@fb.com>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 23578 bytes --]