From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755484AbbKYCLl (ORCPT ); Tue, 24 Nov 2015 21:11:41 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:54421 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755432AbbKYCLk (ORCPT ); Tue, 24 Nov 2015 21:11:40 -0500 Subject: Re: [PATCH 1/2] sp5100_tco: fix the device check for SB800 and later chipsets To: Huang Rui References: <1448273256-1793-1-git-send-email-ray.huang@amd.com> <56546CEB.3080907@roeck-us.net> <20151125015916.GA2904@hr-amur2> Cc: Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Denis Turischev , Borislav Petkov , Vincent Wan , Tony Li From: Guenter Roeck Message-ID: <565518D5.4010104@roeck-us.net> Date: Tue, 24 Nov 2015 18:11:33 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151125015916.GA2904@hr-amur2> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/2015 05:59 PM, Huang Rui wrote: > On Tue, Nov 24, 2015 at 05:58:03AM -0800, Guenter Roeck wrote: >> On 11/23/2015 02:07 AM, Huang Rui wrote: >>> For SB800 and later chipsets, the register definitions are the same >>> with SB800. And for SB700 and older chipsets, the definitions should >>> be same with SP5100/SB7x0. >>> >>> Signed-off-by: Huang Rui >>> Cc: Denis Turischev >> >> Reviewed-by: Guenter Roeck >> >> Would it make sense to rework this driver as pci driver ? >> > > I agree with you. Actually, I thought about this stuff. But sp5100 > watchdog is not a pci device in AMD chipset. In another word, it > doesn't export a pci header to OS. At current, we use SMBus pci device > id and vendor id to detect watchdog on the AMD chipset (Because AMD > use SMBus device id and revsion to identify different chipset > version). At the same time, SMbus has its own driver piix4_smbus. > Looks like we don't have a pci header to enumerate the watchdog. > Ok, thanks for the clarification. Odd way to detect the chip, but I guess one has to use what is available. Thanks, Guenter