[PATCH] mm/compaction: improve comment for compact_memory tunable knob handler

[PATCH] mm/compaction: improve comment for compact_memory tunable knob handler

[Yaowei Bai]

Sysctl_compaction_handler() is the handler function for compact_memory
tunable knob under /proc/sys/vm, add the missing knob name to make this
more accurate in comment.

No functional change.

Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
---
 mm/compaction.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index de3e1e7..ac6c694 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1708,7 +1708,10 @@ static void compact_nodes(void)
 /* The written value is actually unused, all memory is compacted */
 int sysctl_compact_memory;
 
-/* This is the entry point for compacting all nodes via /proc/sys/vm */
+/*
+ * This is the entry point for compacting all nodes via
+ * /proc/sys/vm/compact_memory
+ */
 int sysctl_compaction_handler(struct ctl_table *table, int write,
 			void __user *buffer, size_t *length, loff_t *ppos)
 {
-- 
1.9.1

Re: [PATCH] mm/compaction: improve comment for compact_memory tunable knob handler

[Vlastimil Babka]

On 11/25/2015 10:07 AM, Yaowei Bai wrote:
> Sysctl_compaction_handler() is the handler function for compact_memory
> tunable knob under /proc/sys/vm, add the missing knob name to make this
> more accurate in comment.
> 
> No functional change.
> 
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
>  mm/compaction.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index de3e1e7..ac6c694 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1708,7 +1708,10 @@ static void compact_nodes(void)
>  /* The written value is actually unused, all memory is compacted */
>  int sysctl_compact_memory;
>  
> -/* This is the entry point for compacting all nodes via /proc/sys/vm */
> +/*
> + * This is the entry point for compacting all nodes via
> + * /proc/sys/vm/compact_memory
> + */
>  int sysctl_compaction_handler(struct ctl_table *table, int write,
>  			void __user *buffer, size_t *length, loff_t *ppos)
>  {
> 

Re: [PATCH] mm/compaction: improve comment for compact_memory tunable knob handler

[Michal Nazarewicz]

On Wed, Nov 25 2015, Yaowei Bai wrote:
> Sysctl_compaction_handler() is the handler function for compact_memory
> tunable knob under /proc/sys/vm, add the missing knob name to make this
> more accurate in comment.
>
> No functional change.
>
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>

Since I'm explicitly on CC, I might just as well:

Acked-by: Michal Nazarewicz <mina86@mina86.com>

> ---
>  mm/compaction.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index de3e1e7..ac6c694 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1708,7 +1708,10 @@ static void compact_nodes(void)
>  /* The written value is actually unused, all memory is compacted */
>  int sysctl_compact_memory;
>  
> -/* This is the entry point for compacting all nodes via /proc/sys/vm */
> +/*
> + * This is the entry point for compacting all nodes via
> + * /proc/sys/vm/compact_memory
> + */
>  int sysctl_compaction_handler(struct ctl_table *table, int write,
>  			void __user *buffer, size_t *length, loff_t *ppos)
>  {
> -- 
> 1.9.1
>
>
>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  ミハウ “mina86” ナザレヴイツ  (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--