From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752084AbbKYKb5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Nov 2015 05:31:57 -0500
Received: from smtp2-g21.free.fr ([212.27.42.2]:26630 "EHLO smtp2-g21.free.fr"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751548AbbKYKb4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Nov 2015 05:31:56 -0500
Subject: Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx
 interrupt controller
To: Mans Rullgard <mans@mansr.com>, linux-kernel@vger.kernel.org
References: <1447958026-3015-1-git-send-email-mans@mansr.com>
 <1447958026-3015-3-git-send-email-mans@mansr.com>
From: Mason <slash.tmp@free.fr>
Cc: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>
Message-ID: <56558E13.6030703@free.fr>
Date: Wed, 25 Nov 2015 11:31:47 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101
 Firefox/42.0 SeaMonkey/2.39
MIME-Version: 1.0
In-Reply-To: <1447958026-3015-3-git-send-email-mans@mansr.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[ Trimming CC list ]

On 19/11/2015 19:33, Mans Rullgard wrote:

> +config TANGOX_IRQ

Could you drop the X?
(And perhaps change IRQ to IRQCHIP? What's the current trend?)

> +	bool
> +	select IRQ_DOMAIN
> +	select GENERIC_IRQ_CHIP

Could you sort alphabetically, like the mach Kconfig?

Regards.