* [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
@ 2015-11-25 11:36 Ching Huang
2015-11-25 11:59 ` Johannes Thumshirn
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ching Huang @ 2015-11-25 11:36 UTC (permalink / raw)
To: hch, thenzl, jbottomley, dan.carpenter, agordeev, linux-scsi,
linux-kernel, hare, jthumshirn
Cc: hch
From: Ching Huang <ching2048@areca.com.tw>
Fixed getting wrong configuration data of adapter type B and type D.
Signed-of-by: Ching Huang <ching2048@areca.com.tw>
---
diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
--- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-23 16:25:22.000000000 +0800
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000 +0800
@@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
acb->firm_model,
acb->firm_version);
- acb->signature = readl(®->message_rwbuffer[1]);
+ acb->signature = readl(®->message_rwbuffer[0]);
/*firm_signature,1,00-03*/
- acb->firm_request_len = readl(®->message_rwbuffer[2]);
+ acb->firm_request_len = readl(®->message_rwbuffer[1]);
/*firm_request_len,1,04-07*/
- acb->firm_numbers_queue = readl(®->message_rwbuffer[3]);
+ acb->firm_numbers_queue = readl(®->message_rwbuffer[2]);
/*firm_numbers_queue,2,08-11*/
- acb->firm_sdram_size = readl(®->message_rwbuffer[4]);
+ acb->firm_sdram_size = readl(®->message_rwbuffer[3]);
/*firm_sdram_size,3,12-15*/
- acb->firm_hd_channels = readl(®->message_rwbuffer[5]);
+ acb->firm_hd_channels = readl(®->message_rwbuffer[4]);
/*firm_ide_channels,4,16-19*/
acb->firm_cfg_version = readl(®->message_rwbuffer[25]); /*firm_cfg_version,25,100-103*/
/*firm_ide_channels,4,16-19*/
@@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
iop_device_map++;
count--;
}
- acb->signature = readl(®->msgcode_rwbuffer[1]);
+ acb->signature = readl(®->msgcode_rwbuffer[0]);
/*firm_signature,1,00-03*/
- acb->firm_request_len = readl(®->msgcode_rwbuffer[2]);
+ acb->firm_request_len = readl(®->msgcode_rwbuffer[1]);
/*firm_request_len,1,04-07*/
- acb->firm_numbers_queue = readl(®->msgcode_rwbuffer[3]);
+ acb->firm_numbers_queue = readl(®->msgcode_rwbuffer[2]);
/*firm_numbers_queue,2,08-11*/
- acb->firm_sdram_size = readl(®->msgcode_rwbuffer[4]);
+ acb->firm_sdram_size = readl(®->msgcode_rwbuffer[3]);
/*firm_sdram_size,3,12-15*/
- acb->firm_hd_channels = readl(®->msgcode_rwbuffer[5]);
+ acb->firm_hd_channels = readl(®->msgcode_rwbuffer[4]);
/*firm_hd_channels,4,16-19*/
acb->firm_cfg_version = readl(®->msgcode_rwbuffer[25]);
pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
2015-11-25 11:36 [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Ching Huang
@ 2015-11-25 11:59 ` Johannes Thumshirn
2015-11-25 12:04 ` Hannes Reinecke
2015-12-01 0:17 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2015-11-25 11:59 UTC (permalink / raw)
To: Ching Huang
Cc: hch, hch, thenzl, jbottomley, dan.carpenter, agordeev, linux-scsi,
linux-kernel, hare
On Wed, 2015-11-25 at 19:36 +0800, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
>
> Fixed getting wrong configuration data of adapter type B and type D.
>
> Signed-of-by: Ching Huang <ching2048@areca.com.tw>
>
> ---
>
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c
> b/drivers/scsi/arcmsr/arcmsr_hba.c
> --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-23 16:25:22.000000000
> +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2015-11-24 11:35:26.000000000
> +0800
> @@ -2694,15 +2694,15 @@ static bool arcmsr_hbaB_get_config(struc
> acb->firm_model,
> acb->firm_version);
>
> - acb->signature = readl(®->message_rwbuffer[1]);
> + acb->signature = readl(®->message_rwbuffer[0]);
> /*firm_signature,1,00-03*/
> - acb->firm_request_len = readl(®->message_rwbuffer[2]);
> + acb->firm_request_len = readl(®->message_rwbuffer[1]);
> /*firm_request_len,1,04-07*/
> - acb->firm_numbers_queue = readl(®->message_rwbuffer[3]);
> + acb->firm_numbers_queue = readl(®->message_rwbuffer[2]);
> /*firm_numbers_queue,2,08-11*/
> - acb->firm_sdram_size = readl(®->message_rwbuffer[4]);
> + acb->firm_sdram_size = readl(®->message_rwbuffer[3]);
> /*firm_sdram_size,3,12-15*/
> - acb->firm_hd_channels = readl(®->message_rwbuffer[5]);
> + acb->firm_hd_channels = readl(®->message_rwbuffer[4]);
> /*firm_ide_channels,4,16-19*/
> acb->firm_cfg_version = readl(®-
> >message_rwbuffer[25]); /*firm_cfg_version,25,100-103*/
> /*firm_ide_channels,4,16-19*/
> @@ -2880,15 +2880,15 @@ static bool arcmsr_hbaD_get_config(struc
> iop_device_map++;
> count--;
> }
> - acb->signature = readl(®->msgcode_rwbuffer[1]);
> + acb->signature = readl(®->msgcode_rwbuffer[0]);
> /*firm_signature,1,00-03*/
> - acb->firm_request_len = readl(®->msgcode_rwbuffer[2]);
> + acb->firm_request_len = readl(®->msgcode_rwbuffer[1]);
> /*firm_request_len,1,04-07*/
> - acb->firm_numbers_queue = readl(®->msgcode_rwbuffer[3]);
> + acb->firm_numbers_queue = readl(®->msgcode_rwbuffer[2]);
> /*firm_numbers_queue,2,08-11*/
> - acb->firm_sdram_size = readl(®->msgcode_rwbuffer[4]);
> + acb->firm_sdram_size = readl(®->msgcode_rwbuffer[3]);
> /*firm_sdram_size,3,12-15*/
> - acb->firm_hd_channels = readl(®->msgcode_rwbuffer[5]);
> + acb->firm_hd_channels = readl(®->msgcode_rwbuffer[4]);
> /*firm_hd_channels,4,16-19*/
> acb->firm_cfg_version = readl(®->msgcode_rwbuffer[25]);
> pr_notice("Areca RAID Controller%d: Model %s, F/W %s\n",
>
>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
2015-11-25 11:36 [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Ching Huang
2015-11-25 11:59 ` Johannes Thumshirn
@ 2015-11-25 12:04 ` Hannes Reinecke
2015-12-01 0:17 ` Martin K. Petersen
2 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2015-11-25 12:04 UTC (permalink / raw)
To: Ching Huang, hch, thenzl, jbottomley, dan.carpenter, agordeev,
linux-scsi, linux-kernel, jthumshirn
Cc: hch
On 11/25/2015 12:36 PM, Ching Huang wrote:
> From: Ching Huang <ching2048@areca.com.tw>
>
> Fixed getting wrong configuration data of adapter type B and type D.
>
> Signed-of-by: Ching Huang <ching2048@areca.com.tw>
>
> ---
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
2015-11-25 11:36 [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Ching Huang
2015-11-25 11:59 ` Johannes Thumshirn
2015-11-25 12:04 ` Hannes Reinecke
@ 2015-12-01 0:17 ` Martin K. Petersen
2015-12-01 2:51 ` Ching Huang
2 siblings, 1 reply; 5+ messages in thread
From: Martin K. Petersen @ 2015-12-01 0:17 UTC (permalink / raw)
To: Ching Huang
Cc: hch, thenzl, jbottomley, dan.carpenter, agordeev, linux-scsi,
linux-kernel, hare, jthumshirn, hch
>>>>> "Ching" == Ching Huang <ching2048@areca.com.tw> writes:
Hello Ching,
I applied both your series to 4.5/scsi-queue.
In the future please run checkpatch before submitting. Warnings are OK
but in this case there were several things flagged as errors that I had
to fix up by hand.
Also make sure you tag with "Signed-off-by:". Your signoff was mistyped
in all the patches.
Thank you!
Martin
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data
2015-12-01 0:17 ` Martin K. Petersen
@ 2015-12-01 2:51 ` Ching Huang
0 siblings, 0 replies; 5+ messages in thread
From: Ching Huang @ 2015-12-01 2:51 UTC (permalink / raw)
To: Martin K. Petersen
Cc: hch, thenzl, jbottomley, dan.carpenter, agordeev, linux-scsi,
linux-kernel, hare, jthumshirn, hch
On Mon, 2015-11-30 at 19:17 -0500, Martin K. Petersen wrote:
> >>>>> "Ching" == Ching Huang <ching2048@areca.com.tw> writes:
>
> Hello Ching,
>
> I applied both your series to 4.5/scsi-queue.
>
> In the future please run checkpatch before submitting. Warnings are OK
> but in this case there were several things flagged as errors that I had
> to fix up by hand.
>
> Also make sure you tag with "Signed-off-by:". Your signoff was mistyped
> in all the patches.
>
> Thank you!
> Martin
>
Thanks Martin's effort and advice.
I will pay attention on future submitting.
Best Regards,
Ching
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-12-01 2:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-25 11:36 [PATCH v3 1/5] arcmsr: fixed getting wrong configuration data Ching Huang
2015-11-25 11:59 ` Johannes Thumshirn
2015-11-25 12:04 ` Hannes Reinecke
2015-12-01 0:17 ` Martin K. Petersen
2015-12-01 2:51 ` Ching Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox