From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>,
vinod.koul@intel.com, tiwai@suse.com, broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com
Subject: Re: [alsa-devel] [PATCH 2/2] ALSA: compress: Pass id string to snd_compress_new
Date: Wed, 25 Nov 2015 08:51:20 -0600 [thread overview]
Message-ID: <5655CAE8.80705@linux.intel.com> (raw)
In-Reply-To: <1448444918-29760-3-git-send-email-rf@opensource.wolfsonmicro.com>
> @@ -689,7 +689,13 @@ int snd_soc_new_compress(struct snd_soc_pcm_runtime *rtd, int num)
> compr->ops->copy = soc_compr_copy;
>
> mutex_init(&compr->lock);
> - ret = snd_compress_new(rtd->card->snd_card, num, direction, compr);
> +
> + snprintf(new_name, sizeof(new_name), "%s %s-%d",
> + rtd->dai_link->stream_name,
> + rtd->codec_dai->name, num);
Adding an ID with a human-readable name sounds good.
Wondering though if the codec_dai name is relevant for compressed
streams? In all the configurations we have with DPCM the name is
snd-soc-dummy-dai, there is no connection to the codec proper.
stream_name and id should be good enough, no?
next prev parent reply other threads:[~2015-11-25 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 9:48 [PATCH 0/2] ALSA: compress: Add procfs info file for compressed nodes Richard Fitzgerald
2015-11-25 9:48 ` [PATCH 1/2] " Richard Fitzgerald
2015-11-25 9:48 ` [PATCH 2/2] ALSA: compress: Pass id string to snd_compress_new Richard Fitzgerald
2015-11-25 10:15 ` kbuild test robot
2015-11-25 14:51 ` Pierre-Louis Bossart [this message]
2015-11-25 15:15 ` [alsa-devel] " Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5655CAE8.80705@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox