Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags

James Hogan
2015-12-10T12:26:56Z

On 9 December 2015 at 11:29, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 04 December 2015 16:16:33 Vlastimil Babka wrote:
>> --- a/include/linux/mmdebug.h
>> +++ b/include/linux/mmdebug.h
>> @@ -2,15 +2,20 @@
>> #define LINUX_MM_DEBUG_H 1
>>
>> #include <linux/stringify.h>
>> +#include <linux/types.h>
>> +#include <linux/tracepoint.h>
>
> 8<-----
> Subject: mm: fix generated/bounds.h
>
> The inclusion of linux/tracepoint.h is causing build errors for me in ARM
> randconfig:
>
> In file included from /git/arm-soc/include/linux/ktime.h:25:0,
> from /git/arm-soc/include/linux/rcupdate.h:47,
> from /git/arm-soc/include/linux/tracepoint.h:19,
> from /git/arm-soc/include/linux/mmdebug.h:6,
> from /git/arm-soc/include/linux/page-flags.h:10,
> from /git/arm-soc/kernel/bounds.c:9:
> /git/arm-soc/include/linux/jiffies.h:10:33: fatal error: generated/timeconst.h: No such file or directory
> compilation terminated.
>
> To work around this, we can stop including linux/mmdebug.h from linux/page_flags.h
> while generating bounds.h, as we do for mm_types.h already.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8c0d593d0f8f ("mm, printk: introduce new format string for flags")
>
> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
> index 19724e6ebd26..4efad0578a28 100644
> --- a/include/linux/page-flags.h
> +++ b/include/linux/page-flags.h
> @@ -7,8 +7,8 @@
>
> #include <linux/types.h>
> #include <linux/bug.h>
> -#include <linux/mmdebug.h>
> #ifndef __GENERATING_BOUNDS_H
> +#include <linux/mmdebug.h>
> #include <linux/mm_types.h>
> #include <generated/bounds.h>
> #endif /* !__GENERATING_BOUNDS_H */

Same build issue observed for metag too.
Tested-by: James Hogan <james.hogan@imgtec.com>

Cheers
James