Re: [PATCH 02/14] irqchip: irq-pic32-evic: Add support for PIC32 interrupt controller

[Joshua Henderson <joshua.henderson@microchip.com>]

On 11/22/2015 4:45 AM, Marc Zyngier wrote:
> On Fri, 20 Nov 2015 17:17:14 -0700
> Joshua Henderson <joshua.henderson@microchip.com> wrote:
> 
> Joshua, Cristian,
> 
>> From: Cristian Birsan <cristian.birsan@microchip.com>
>>
>> This adds support for the EVIC present on a PIC32MZDA.
>>
>> The following features are supported:
>>  - DT properties for EVIC and for devices that use interrupt lines
>>  - persistent and non-persistent interrupt handling
>>  - Priority, sub-priority and polariy settings for each interrupt line
>>  - irqdomain support
>>
> 
> I haven't reviewed the code yet, but the fact that you allow (and
> actually request) the interrupt priorities to be encoded in the DT
> raises some concerns:
> 
> - Aren't priorities entirely under software control (and hence don't
>   belong in DT)?

These are hardware priorities configured by software.  They arbitrate pending hardware interrupts to the CPU.  We can agree that DT is probably not the best place for this configuration.  They will be removed from the binding.

> - More crucially, how do you deal with nested interrupts when you have
>   interrupts running at different priorities? Most parts of Linux
>   cannot cope with that without additional support.
> 

We do not support nested interrupts.

> Thanks,
> 
> 	M.
>