From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-acpi@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5] acpi: add support for extended IRQ to PCI link
Date: Wed, 25 Nov 2015 13:28:06 -0500 [thread overview]
Message-ID: <5655FDB6.1020608@codeaurora.org> (raw)
In-Reply-To: <20151125172704.GE1380@localhost>
On 11/25/2015 12:27 PM, Bjorn Helgaas wrote:
> Maybe reword the diagnostic to make it clear that we're ignoring this
> IRQ information. It'd really be nice if the message had a clue about
> what it applies to, i.e., the ACPI device path or something,
Are we OK with print strings exceeding 80 characters to include detailed
information? Chris Covington pointed out to me that there are exceptions
to 80 characters when it comes to print format strings.
"The limit on the length of lines is 80 columns and this is a strongly
preferred limit. ... However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them."
--
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
Linux Foundation Collaborative Project
prev parent reply other threads:[~2015-11-25 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 20:10 [PATCH V5] acpi: add support for extended IRQ to PCI link Sinan Kaya
2015-11-25 14:27 ` Sinan Kaya
2015-11-25 17:27 ` Bjorn Helgaas
2015-11-25 18:28 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5655FDB6.1020608@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=cov@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=jcm@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox