From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbbKYUGD (ORCPT ); Wed, 25 Nov 2015 15:06:03 -0500 Received: from mail-bl2on0093.outbound.protection.outlook.com ([65.55.169.93]:19850 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752659AbbKYUF4 (ORCPT ); Wed, 25 Nov 2015 15:05:56 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@caviumnetworks.com; Message-ID: <5656149D.50704@caviumnetworks.com> Date: Wed, 25 Nov 2015 12:05:49 -0800 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Arnd Bergmann CC: , Bjorn Helgaas , David Daney , David Daney , Marc Zyngier , Catalin Marinas , Will Deacon , , "Sean O. Stalley" , , Bjorn Helgaas Subject: Re: [RFC PATCH] PCI/pci-host-generic: Add support for Cavium Thunder fixed BARs. References: <1443488184-12633-1-git-send-email-ddaney.cavm@gmail.com> <20151125170652.GC1380@localhost> <2789794.TBZL2yW2b6@wuerfel> In-Reply-To: <2789794.TBZL2yW2b6@wuerfel> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.2.3.194] X-ClientProxiedBy: DM2PR07CA0023.namprd07.prod.outlook.com (10.141.52.151) To DM3PR07MB2137.namprd07.prod.outlook.com (25.164.4.143) X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;2:mltVvP88AsxfFv16xG0JrauoJXFxnkT5DmNrGy0pU4r85l027H2fv3cUKsVjVuEPr6fo+kwZYbnf+3F1d73bLWNQwPpGZOyLqE1gZfFtRc2ajwgi8n8NdNvIooTcXpfo6Zi30lGm2WeuK9sa3Fa17w==;3:Za3zEKw6YlIUK1yujZG79W7Z+ZOFabLn8Q6mtEhYfvlPr4ALnbHDUwoHEG5hwIhryapGwlZPzscJi065viutCz1aeN6PzuVtKYAZfddVhJft0dd7yrjUBnoJSXRiMrr6;25:6hVZSBwZqOs7HIz3knK7sPiCZnOQ9NIyRC7DuVmsIb9Y7/6eb0U2QqIex0mUmZVNF/UjzL9KfTnvknjjXNBNw0PH4YvobpbPX9eWAgBLwC1iWKNcLJXEh3giFnVwc84bxsDyR+sLtwO/QW4WX1lcnLies8lPEANXCGIl4zNVBSE6eMBJCPn0UczNdC58mmWUT8rXu2acGFshcJMTh7VuyoxsOZ/kwPQfQSOBFgTd6pHtfPDvjKB+E/0K16YPmcXyY/eGBFarao4nhalAVpRtBg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2137; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;20:sxW2+cbGr0QW6T24fPu2a+dBEYYrPoM+W/F4RCg15mxqmqdKmJSHrvMf7WZ50imLKAtKkWHMa96sJHYFrg/QeVyJphCKCvtJcJWc/I+KUyn7Di1CqDhp6e1rft7biD6oJRkU4Y4M/MU4OkV9sk+o5KMNOG0ntH7XhUUHRAnJMVEN/KTue38uTryyupEFoU8YEwtL1aG/YuhJ9/xzgz3WR5IHq8jgyvNRe9xIt7LETkFWu3smgSvTdC3t0YSgR8UaHZR1GZP5Tu3tjAO6LplHewip/GufFosvunW19k/CJ4Rei/FA6OI+S2sdkEdJvVwZJoNZQqzbyoBjpz9cAPG6jmnn/39Rb0qrpkchYity8X8KFgctsvwkUZ2Dqrxuv/DNT04ALEfi24SBqs8j+LkEXFyI7v4HQLLP/DAQyPyqfeXvcbEoI0KGfWlCy/RVlnzd8TARiWQsvNbVT9Xa2Aca219uBIIg77QI5x8DwsDK1yufIUdyjsO0X6TKtSofhtakw7UPcd471xXA33VXdrOPI2BOrKWvB2Tn0qWegn/fwaH0T9vLVOzv/CLE9A0eGl5MPQGC1Uf8e9F3OGNXSlokOkRqOkM7OkYgFYXqQd8CNGQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(10201501046)(3002001);SRVR:DM3PR07MB2137;BCL:0;PCL:0;RULEID:;SRVR:DM3PR07MB2137; X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;4:UU/owU5R1uf/XymwnAVHVY8lx5Hwt010RqyvKqHbWHZM4PFle+DNxl/6WPuuK8vJRoF5QVTeV+veyzgCyV4aBloYNW0Yw3b290GtcES5aJ7Xv8zkv1HpM+UngDIBgdIpbZDdZ+TjVYMYQMdwHx2nAgubfQsiNtQZBhRVLO4aKMBkiDiE8sz00V/KiNEtbmu/xwOQ3crKstem2+ZgDkRvFSVc0u1jUsS2fYGEVhmclCJsqDz0X3zLqOYjYde8VD0qHvp+wTRux/2STCoaO4Oh+rBpj0WCxEdeSK4/kddRnyCkHU5Yh+QJCdBXkTLeGSzwm6weWpfkPLAk9/EPltJvdNTYjJw6lWkfk80LioBn4UVpwV9rewfuCxGJgpkLzKqN X-Forefront-PRVS: 0771670921 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(24454002)(377454003)(479174004)(50466002)(42186005)(54356999)(5001920100001)(36756003)(2950100001)(5008740100001)(64126003)(65956001)(53416004)(81156007)(4001350100001)(106356001)(6116002)(92566002)(5004730100002)(77096005)(76176999)(5001960100002)(230700001)(50986999)(105586002)(19580395003)(47776003)(122386002)(66066001)(65816999)(230783001)(65806001)(23756003)(87976001)(69596002)(40100003)(110136002)(83506001)(101416001)(19580405001)(586003)(3846002)(97736004)(33656002)(189998001)(1096002)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM3PR07MB2137;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;DM3PR07MB2137;23:+yCegJsq0ba4l66sQlV1wEuMruBTvb7yOMnANAZ?= =?iso-8859-1?Q?yUPRUfR2hlXr01hfRB0sNvPiH2UcLEbCOOv/CeCzraOckN/Ba/0MtmIMQv?= =?iso-8859-1?Q?NKdvVwo3b/VP5R6fb5D5+shAZ1b0lZX9uP7dPftmSUgeEbgYomw6jkN3OR?= =?iso-8859-1?Q?1spwNyhn8xpti54QOkILCUJTQ5CpTbWfjr949kdFMgeSRQLWegwWBOAW0Q?= =?iso-8859-1?Q?JElUe//HM6ln4MXv6d7YGTjIZQ/LzGlFuUBb8ym5O4eeo4uJSelYJT0jdw?= =?iso-8859-1?Q?ZGhYWNJkydD9ozWjbyufnQf4RmdE8OBF1DLNDvx1pU2w/Ju5siJ0OeMRuk?= =?iso-8859-1?Q?uBdRLIP+UANdKIhTTWEeeU02X2VqgBC3rsliEQFXEFtkvdsf8SzEoIcGvK?= =?iso-8859-1?Q?b4Q8I33XKKf+IomyQU/mBdXrEdGWgCAEbxdLBT1nEso5+bpJ7KgeUfxW3u?= =?iso-8859-1?Q?+CIkzQBKXXPj/WAdKzu5dBCDIGMNJfTOoH/FQ3FS+F5QyxWp8IBqnvnuSv?= =?iso-8859-1?Q?nF9o+B0HXr7b4CInZcETaewHRm88+SI6b4+FkNFiWDuPZBAsMXvivVdJJ2?= =?iso-8859-1?Q?5fQOaRcclTo8Ok9nxHJjCg2e5B1C3KM9H8DwVv1fxsUTMpLu/BmMS+Gqd/?= =?iso-8859-1?Q?GaCufDasBOm8tjCTx2yqV8RVtznnIT6+rWHt/qDOgSjBUV6TqdRIDR1aXm?= =?iso-8859-1?Q?t6XRU2bpz7hjsJ+50RefeZbGB1pJs8oGIN9npi5qa47IOA0YfGjgnHRiMC?= =?iso-8859-1?Q?jC0jVe/6BC7QQjkQ10ej7AeNhNq+GxDLNCyXcgMfskcpZSao3oKQs3D6G0?= =?iso-8859-1?Q?ulvCJYcwGkdFlbKdlMjS+BFNvA5I/b2hINHN5ZiTzOT66z6rX355XG3OP9?= =?iso-8859-1?Q?eeJ7ys9MEpye7/w/wTxle6vu9q9w8j+lnr6l8ieiFnY7TU0fE+WrqlcKsg?= =?iso-8859-1?Q?MUmfryOr/19YFhjBXqLS5huYHd0D5CX0rLCYPjRNO3wuAkdq2WhVr/RRDc?= =?iso-8859-1?Q?e0XcHwLb7eai+Him54xzlVeJJcwXR76VVOkY6EOhS7GCQGFucsK7CyFha+?= =?iso-8859-1?Q?68v7wgE775HU5W9CfMdVNPhPAP7Pr7eNTC9gKqnqnD6SnmTuZtRc/H0GaW?= =?iso-8859-1?Q?EbHOq+wFPYsBqGzVdPFQUn+Y5irU/4bzEejmUQYPz9P6JpjApSTYrOQw2C?= =?iso-8859-1?Q?HqFsjS3pkeUh6KaKkuztsKGcP8UD98JuAUUx2o9dGy7O/mInf+UxY/fZwc?= =?iso-8859-1?Q?/bBBO8OQqjWv+mrJ9S+HZJaDjMNCXapuk68RkkLDT+Pf0TqoQQQsKMyvYC?= =?iso-8859-1?Q?y+uKk2X5DEJDyB9vUSRxgwaeskZLH7som4DzH95/MsYOQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM3PR07MB2137;5:sk1PLJGq7j1XyKIGOWuM1OE1cVm9DHjgRJ4g7krYHjLs7WonQ4udhqu1QjoP3Tq+CeCFE+FMLzoHNOeJYU2dU0xFwwuj4ImPDQJqVSyLL4M5kYNeKP/2B3gWAFL15fhyfWFp3BsjGBNssnPGtJmZpA==;24:0ePfMBUmbzl8KmymN/vpncAg9SZrJooCO99atGG7z5+jXcpYoc6SkobfU5a2m8F27xswTSp33SilQbv9Ksnp4iqDXoM2HeGw+gh/+t5uW88= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2015 20:05:51.9110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2137 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2015 11:52 AM, Arnd Bergmann wrote: > On Wednesday 25 November 2015 11:06:52 Bjorn Helgaas wrote: >> >> On Mon, Sep 28, 2015 at 05:56:24PM -0700, David Daney wrote: >>> From: David Daney >>> >>> Early versions of the Cavium Thunder CN88XX processor are missing >>> Enhanced Allocation (EA) capabilities for the fixed BAR addresses used >>> by the on-SoC hardware blocks. >>> >>> Add config access functions that synthesize the missing EA >>> capabilities for versions that are missing that information. Since >>> this is a little hacky, gate the inclusion of the code with a new >>> Kconfig variable. >>> >>> Signed-off-by: David Daney >> >> What about this one? Do we still need it? This version looks like it >> still has some debug code and it feels like a lot of hard-coding of >> config offsets; it'd be nice if it could be more table-driven. But >> maybe this isn't needed anymore anyway. > > I still think it doesn't belong into the generic driver. We have the > abstraction for drivers based on the compatible string to handle > nonstandard PCI host bridges, and the generic driver should really > just handle the generic code. Somebody should make a decision about this point. Here is what happens: 1) A driver for non-generic PCI host bridge is submitted. 2) Comments are received stating that it is just another PCI host bridge and please use pci-host-generic instead. 3) Patches to pci-host-generic are submitted. 4) Comments are received stating that pci-host-generic is for generic things only, and please create a device specific driver. 5) goto 1 > > It's easy enough to split out the common parts if we want to reuse > some of this, or to move them into drivers/pci/*.c for others to > reuse too. > If we do that, do you want "pci-host-cam-generic" and "pci-host-ecam-generic" split out too? They are two completely different things crammed into the single pci-host-generic driver source file. Or is there some set of config access methods that are sufficiently generic that they can stay? David Daney > Arnd >