From: David Ahern <dsahern@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 3/3] perf script: Align event name properly
Date: Thu, 26 Nov 2015 07:25:17 -0700 [thread overview]
Message-ID: <5657164D.1080606@gmail.com> (raw)
In-Reply-To: <1448546125-29245-3-git-send-email-jolsa@kernel.org>
On 11/26/15 6:55 AM, Jiri Olsa wrote:
> Adding code to align event names, so we get aligned output
> in case of multiple events with different names.
>
> Before:
> $ perf script
> :13757 13757 163918.230829: cpu/mem-snp-none/P: ffff88085f20d010
> :13757 13757 163918.230832: cpu/mem-loads,ldlat=30/P: 7f5a5f719f00
> :13757 13757 163918.230835: cpu/mem-loads,ldlat=30/P: 7f5a5f719f00
> :13758 13758 163918.230838: cpu/mem-snp-none/P: ffff88085f4ad810
> :13758 13758 163918.154093: cpu/mem-stores/P: ffff88085bb53f28
> :13757 13757 163918.155264: cpu/mem-snp-hitm/P: 601080
> ...
>
What's up with the ":13757" for the process name?
Patches LGTM
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2015-11-26 14:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 13:55 [PATCH 1/3] perf script: Remove default_scripting_ops Jiri Olsa
2015-11-26 13:55 ` [PATCH 2/3] perf script: Pass perf_script into process_event Jiri Olsa
2015-11-26 16:22 ` Arnaldo Carvalho de Melo
2015-11-26 17:55 ` [PATCHv2 " Jiri Olsa
2015-11-27 7:45 ` [tip:perf/core] " tip-bot for Jiri Olsa
2015-11-26 13:55 ` [PATCH 3/3] perf script: Align event name properly Jiri Olsa
2015-11-26 14:25 ` David Ahern [this message]
2015-11-26 14:30 ` Jiri Olsa
2015-11-26 14:34 ` David Ahern
2015-12-27 11:59 ` Jiri Olsa
2015-11-26 16:33 ` [PATCH 1/3] perf script: Remove default_scripting_ops Arnaldo Carvalho de Melo
2015-11-27 7:43 ` [tip:perf/core] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5657164D.1080606@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox