From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752814AbbKZPsW (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Nov 2015 10:48:22 -0500
Received: from mail-ob0-f180.google.com ([209.85.214.180]:34318 "EHLO
	mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751416AbbKZPsV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Nov 2015 10:48:21 -0500
Subject: Re: [PATCH 2/3] perf callchain: Stop resolving callchains after
 invalid address
To: Namhyung Kim <namhyung@kernel.org>
References: <1448521700-32062-1-git-send-email-namhyung@kernel.org>
 <1448521700-32062-2-git-send-email-namhyung@kernel.org>
 <565705D1.705@gmail.com> <20151126150018.GA21474@danjae.kornet>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, Jiri Olsa <jolsa@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, Kan Liang <kan.liang@intel.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Andi Kleen <andi@firstfloor.org>, Wang Nan <wangnan0@huawei.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <565729C1.4030802@gmail.com>
Date: Thu, 26 Nov 2015 08:48:17 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151126150018.GA21474@danjae.kornet>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/26/15 8:00 AM, Namhyung Kim wrote:
> Hi David,
>
> On Thu, Nov 26, 2015 at 06:14:57AM -0700, David Ahern wrote:
>> On 11/26/15 12:08 AM, Namhyung Kim wrote:
>>> @@ -528,11 +529,16 @@ int main(int argc, const char **argv)
>>>   {
>>>   	const char *cmd;
>>>   	char sbuf[STRERR_BUFSIZE];
>>> +	int min_addr;
>>>
>>>   	/* The page_size is placed in util object. */
>>>   	page_size = sysconf(_SC_PAGE_SIZE);
>>>   	cacheline_size = sysconf(_SC_LEVEL1_DCACHE_LINESIZE);
>>>
>>> +	if (sysctl__read_int("vm/mmap_min_addr", &min_addr) < 0)
>>
>> This assumes the record and analysis are done on the same system.
>
> Right.  Maybe we can just use minimal size (or page size?) or save and
> pass it through somewhere in the feature bit?

no preference, but it should work with cross arch analysis as well 
(e.g., record on arm/ppc and analysis on x86)