Re: [PATCH 2/3] arcmsr: Split dma resource allocation to a new function

[Tomas Henzl <thenzl@redhat.com>]

On 27.11.2015 03:58, Ching Huang wrote:
> On Thu, 2015-11-26 at 11:46 -0800, Joe Perches wrote:
>> On Thu, 2015-11-26 at 19:41 +0800, Ching Huang wrote:
>>> split dma resource allocation and io register assignment from get_config to a new function arcmsr_alloc_io_queue.
>> trivia:
>>
>>> diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
>> []
>>> +static bool arcmsr_alloc_io_queue(struct AdapterControlBlock *acb)
>>> +{
>> []
>>> +		dma_coherent = dma_alloc_coherent(&pdev->dev, acb->roundup_ccbsize,
>>> +			&dma_coherent_handle, GFP_KERNEL);
>>> +		if (!dma_coherent){
>>> +			pr_notice("arcmsr%d: DMA allocation failed.\n", acb->host->host_no);
>>> +			return false;
>>> +		}
>>> +		memset(dma_coherent, 0, acb->roundup_ccbsize);
>>>
>> There is a dma_zalloc_coherent
>>
>> (and even more trivially)
>>
>> Most all of your error messages don't use periods.
> Thanks Joe.
> Revised as below.
>
> Signed-of-by: Ching Huang <ching2048@areca.com.tw>

Reviewed-by: Tomas Henzl <thenzl@redhat.com>

Tomas