From: Zefan Li <lizefan@huawei.com>
To: Oleg Nesterov <oleg@redhat.com>, Aleksa Sarai <cyphar@cyphar.com>,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and cgroup_migrate()
Date: Sat, 28 Nov 2015 11:09:33 +0800 [thread overview]
Message-ID: <56591AED.7050808@huawei.com> (raw)
In-Reply-To: <20151127185705.GA14669@redhat.com>
On 2015/11/28 2:57, Oleg Nesterov wrote:
> On 11/26, Oleg Nesterov wrote:
>>
>> OK. I do not know what exactly do you mean, perhaps if you fix this problem
>> the race between fork and attach goes away and in this case the fix I sent
>> is not needed?
>
> Otherwise please consider this series.
>
> Slightly tested, seems to work; please review.
>
Allowing tasks migrating between cgroups while forking is problematic. I'm more
than glad to see those changes.
Acked-by: Zefan Li <lizefan@huawei.com>
> Oleg.
>
> include/linux/cgroup-defs.h | 12 ++------
> include/linux/cgroup.h | 19 ++++---------
> include/linux/cgroup_subsys.h | 18 ------------
> kernel/cgroup.c | 30 +++++----------------
> kernel/cgroup_freezer.c | 2 +-
> kernel/cgroup_pids.c | 58 +++++++---------------------------------
> kernel/fork.c | 16 ++++-------
> kernel/sched/core.c | 2 +-
> 8 files changed, 34 insertions(+), 123 deletions(-)
>
>
next prev parent reply other threads:[~2015-11-28 3:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 18:57 [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and cgroup_migrate() Oleg Nesterov
2015-11-27 18:57 ` [PATCH 1/3] cgroup: pids: " Oleg Nesterov
2015-11-27 18:57 ` [PATCH 2/3] cgroup: pids: kill pids_fork(), simplify pids_can_fork() and pids_cancel_fork() Oleg Nesterov
2015-11-27 18:57 ` [PATCH 3/3] cgroup: kill cgrp_ss_priv[CGROUP_CANFORK_COUNT] and friends Oleg Nesterov
2015-12-03 15:18 ` Tejun Heo
2015-11-28 3:09 ` Zefan Li [this message]
2015-11-30 15:16 ` [PATCH 0/3] cgroup: fix race between cgroup_post_fork() and cgroup_migrate() Oleg Nesterov
2015-11-30 14:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56591AED.7050808@huawei.com \
--to=lizefan@huawei.com \
--cc=cyphar@cyphar.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox