From: "Christian König" <christian.koenig@amd.com>
To: Pavel Machek <pavel@ucw.cz>,
Trivial patch monkey <trivial@kernel.org>,
<alexander.deucher@amd.com>, <airlied@linux.ie>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [radeon r100] when ring test fails, provide users with option to test
Date: Sun, 29 Nov 2015 20:48:53 +0100 [thread overview]
Message-ID: <565B56A5.4080702@amd.com> (raw)
In-Reply-To: <20151128205840.GA26757@amd>
On 28.11.2015 21:58, Pavel Machek wrote:
> Ring test failure is often caused by too high agpmode. Tell the user
> what to try.
>
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
NAK, the ring test can fail for any number of reasons and the agpmode is
actually rather unlikely to be the cause.
Regards,
Christian.
>
> diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c
> index 238b13f..32b1917 100644
> --- a/drivers/gpu/drm/radeon/r100.c
> +++ b/drivers/gpu/drm/radeon/r100.c
> @@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring)
> if (i < rdev->usec_timeout) {
> DRM_INFO("ring test succeeded in %d usecs\n", i);
> } else {
> - DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n",
> + DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n",
> scratch, tmp);
> r = -EINVAL;
> }
>
next prev parent reply other threads:[~2015-11-29 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 20:58 [radeon r100] when ring test fails, provide users with option to test Pavel Machek
2015-11-29 19:48 ` Christian König [this message]
2015-11-29 22:22 ` Pavel Machek
2015-11-30 8:39 ` Christian König
2015-12-01 10:01 ` Pavel Machek
2015-12-02 3:14 ` Michel Dänzer
2015-12-02 8:57 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565B56A5.4080702@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).